You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/11/19 05:35:13 UTC
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#877: change: avoid duplicate code.
moonming commented on a change in pull request #877: change: avoid duplicate code.
URL: https://github.com/apache/incubator-apisix/pull/877#discussion_r347737748
##########
File path: Makefile
##########
@@ -39,33 +45,30 @@ help:
### deps: Installation dependencies
.PHONY: deps
-deps:
-ifeq ($(OR_EXEC), )
- @echo "OpenResty not found. You have to install OpenResty and add the binary file to PATH before install Apache APISIX."
- exit 1
-else ifeq ($(UNAME),Darwin)
- luarocks install --lua-dir=$(shell ${OR_EXEC} -V 2>&1 | grep prefix | grep -Eo 'prefix=(.*?)/nginx' | grep -Eo '/.*/')luajit rockspec/apisix-0.9-0.rockspec --tree=deps --only-deps --local
+deps: default
+ifeq ($(UNAME),Darwin)
+ luarocks install --lua-dir=$(LUTJIT_DIR) rockspec/apisix-0.9-0.rockspec --tree=deps --only-deps --local
else ifneq ($(LUAROCKS_VER),'luarocks 3.')
luarocks install rockspec/apisix-0.9-0.rockspec --tree=deps --only-deps --local
else
luarocks install --lua-dir=/usr/local/openresty/luajit rockspec/apisix-0.9-0.rockspec --tree=deps --only-deps --local
endif
-### utils: Installation tools
+### utils: Installation linter tools
.PHONY: utils
-utils:
+utils: default
ifeq ($(lj-releng-exist), not_exist)
wget -O utils/lj-releng https://raw.githubusercontent.com/iresty/openresty-devel-utils/iresty/lj-releng
chmod a+x utils/lj-releng
endif
-### check: Check Lua source code
-.PHONY: check
-check:
+### linter: Check code style or error
+.PHONY: linter
+check: default
Review comment:
`check` should be `linter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services