[GitHub] [calcite] asolimando commented on a change in pull request #2529: [CALCITE_4779] GroupSet contains literal, materialized view recognit…

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #2529:
URL: https://github.com/apache/calcite/pull/2529#discussion_r711961236



##########
File path: core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -1607,6 +1607,78 @@ private void checkSatisfiable(RexNode e, String s) {
             + "EnumerableTableScan(table=[[hr, MV0]])")).ok();
   }
 
+  @Test void testGroupSetLiteral() {
+    final String mv = ""
+        + "select \"deptno\", \"empid\"\n"
+        + "from \"emps\"\n"
+        + "group by \"deptno\", \"empid\"";
+    final String query = ""
+        + "select \"deptno\", 1\n"
+        + "from \"emps\"\n"
+        + "group by \"deptno\",  1";
+    sql(mv, query).ok();
+  }
+
+  @Test void testGroupSetMultipleLiteral() {

Review comment:
       Nitpick: `testGroupSetMultipleLiteral` -> `testGroupSetMultipleLiterals` (also in the other test names where literal is plural)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org