You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@gump.apache.org by "Adam R. B. Jack" <aj...@trysybase.com> on 2004/01/30 18:39:28 UTC
CheckStyle on Gump (again, again .. almost there...)
It seems we are getting further (I think) :
http://lsd.student.utwente.nl/gump/checkstyle/checkstyle.html
It seems that most tests pass, except these.
[junit] Running
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest
[junit] Tests run: 5, Failures: 3, Errors: 2, Time elapsed: 0.205 sec
[junit] TEST
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest FAILED
A few questions:
1) Do you need to see the test output in order to debug this? I can arrange
that.
2) Do you think we ought split checkstyle into two projects, one for code,
one for unit tests -- so the *many* folks who depend upon checkstyle still
get Gumped even if a single unit test fails.
3) Do you mind if we change the 'nag' emails to point to the checkstyle-dev
list?
regards
Adam
Re: CheckStyle on Gump (again, again .. almost there...)
Posted by "Adam R. B. Jack" <aj...@trysybase.com>.
Does this help anybody?
1) First we have
2) Next we have the 'offending' file.
3) At far bottom we have the full unit test XML output.
regards,
Adam
----------------------------------------------------------------------------
-------------------------
unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_none.xml
- Declared encoding "UTF-8"; does not match actual one "ASCII"; this might
not be an error."
type="com.puppycrawl.tools.checkstyle.api.CheckstyleException">com.puppycraw
l.tools.checkstyle.api.CheckstyleException: unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_none.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error.
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:155)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:128)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testNoSuppres
sions
----------------------------------------------------------------------------
-------------------------
[ajack@lsd checkstyle]$ more
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_none.xml
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE suppressions PUBLIC
"-//Puppy Crawl//DTD Suppressions 1.0//EN"
"http://www.puppycrawl.com/dtds/suppressions_1_0.dtd">
<suppressions>
</suppressions>
----------------------------------------------------------------------------
----------------------
<?xml version="1.0" encoding="UTF-8" ?>
<testsuite
name="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
tests="5" failures="3" errors="2" time="0.205">
<properties>
<property name="java.vendor" value="Sun Microsystems Inc."></property>
<property name="clover.excludes"
value="**/CheckStyleTas*,**/Generated*.java,**/Java*Recognizer.java,**/Java*
Lexer.java,**/Java*TokenTypes.java,**/gui/*"></property>
<property name="checkstyle.dir"
value="src/checkstyle/com/puppycrawl/tools/checkstyle"></property>
<property name="build.sysclasspath" value="only"></property>
<property name="os.name" value="Linux"></property>
<property name="sun.boot.class.path"
value="/usr/java/j2sdk1.4.2/jre/lib/rt.jar:/usr/java/j2sdk1.4.2/jre/lib/i18n
.jar:/usr/java/j2sdk1.4.2/jre/lib/sunrsasign.jar:/usr/java/j2sdk1.4.2/jre/li
b/jsse.jar:/usr/java/j2sdk1.4.2/jre/lib/jce.jar:/usr/java/j2sdk1.4.2/jre/lib
/charsets.jar:/usr/java/j2sdk1.4.2/jre/classes"></property>
<property name="crimson.jar"
value="${ant.home}/lib/crimson.jar"></property>
<property name="sun.java2d.fontpath" value=""></property>
<property name="java.vm.specification.vendor" value="Sun Microsystems
Inc."></property>
<property name="java.runtime.version" value="1.4.2-b28"></property>
<property name="beanutils.jar"
value="lib/commons-beanutils.jar"></property>
<property name="user.name" value="ajack"></property>
<property name="logging.jar" value="lib/commons-logging.jar"></property>
<property name="clover.lib" value="/apps/clover-1.1.1/lib"></property>
<property name="ant.file.checkstyle"
value="/data/gump/checkstyle/build.xml"></property>
<property name="collections.jar"
value="lib/commons-collections.jar"></property>
<property name="user.language" value="en"></property>
<property name="sun.boot.library.path"
value="/usr/java/j2sdk1.4.2/jre/lib/i386"></property>
<property name="ant.project.name" value="checkstyle"></property>
<property name="java.version" value="1.4.2"></property>
<property name="version" value="20040130"></property>
<property name="user.timezone" value=""></property>
<property name="sun.arch.data.model" value="32"></property>
<property name="java.endorsed.dirs"
value="/usr/java/j2sdk1.4.2/jre/lib/endorsed"></property>
<property name="sun.cpu.isalist" value=""></property>
<property name="file.encoding.pkg" value="sun.io"></property>
<property name="testcases" value="**/*Test.java"></property>
<property name="file.separator" value="/"></property>
<property name="java.specification.name" value="Java Platform API
Specification"></property>
<property name="java.class.version" value="48.0"></property>
<property name="user.country" value="US"></property>
<property name="have.ant15" value="true"></property>
<property name="java.home" value="/usr/java/j2sdk1.4.2/jre"></property>
<property name="dist.dir" value="target/dist"></property>
<property name="java.vm.info" value="mixed mode"></property>
<property name="ant.file"
value="/data/gump/checkstyle/build.xml"></property>
<property name="os.version"
value="2.4.22-1.2129.nptl_24.rhfc1.at"></property>
<property name="path.separator" value=":"></property>
<property name="java.vm.version" value="1.4.2-b28"></property>
<property name="java.util.prefs.PreferencesFactory"
value="java.util.prefs.FileSystemPreferencesFactory"></property>
<property name="java.awt.printerjob"
value="sun.print.PSPrinterJob"></property>
<property name="sun.io.unicode.encoding"
value="UnicodeLittle"></property>
<property name="tests.have.failed" value="true"></property>
<property name="ant.jar" value="${ant.home}/lib/ant.jar"></property>
<property name="user.home" value="/home/ajack"></property>
<property name="java.specification.vendor" value="Sun Microsystems
Inc."></property>
<property name="java.library.path"
value="/usr/java/j2sdk1.4.2/jre/lib/i386/client:/usr/java/j2sdk1.4.2/jre/lib
/i386:/usr/java/j2sdk1.4.2/jre/../lib/i386"></property>
<property name="java.vendor.url"
value="http://java.sun.com/"></property>
<property name="java.vm.vendor" value="Sun Microsystems
Inc."></property>
<property name="have.junit" value="true"></property>
<property name="java.runtime.name" value="Java(TM) 2 Runtime
Environment, Standard Edition"></property>
<property name="java.class.path"
value="/usr/java/j2sdk1.4.2/lib/tools.jar:/data/gump/checkstyle/target/check
style:/data/gump/checkstyle/target/tests:/data/gump/ant/dist/lib/ant-stylebo
ok.jar:/data/gump/ant/dist/lib/ant-jmf.jar:/data/gump/ant/dist/lib/ant-swing
.jar:/data/gump/ant/dist/lib/ant-junit.jar:/data/gump/ant/dist/lib/ant-launc
her.jar:/data/gump/ant/dist/lib/ant-xalan2.jar:/data/gump/ant/dist/lib/ant-t
rax.jar:/data/gump/ant/dist/lib/ant.jar:/data/gump/ant/dist/lib/ant-nodeps.j
ar:/data/gump/jakarta-bcel/bin/bcel.jar:/data/gump/ant/bootstrap/lib/ant-lau
ncher.jar:/data/gump/ant/bootstrap/lib/ant.jar:/data/gump/jakarta-regexp/bui
ld/jakarta-regexp-20040130.jar:/data/gump/dist/junit/junit.jar:/data/gump/op
t/antlr-2.7.2/antlr.jar:/data/gump/opt/antlr-2.7.2/antlrall.jar:/data/gump/j
akarta-commons/beanutils/dist/commons-beanutils.jar:/data/gump/jakarta-commo
ns/cli/target/commons-cli-20040130.jar:/data/gump/jakarta-commons/collection
s/build/commons-collections-20040130.jar!
:/data/gump/jakarta-commons/logging/dist/commons-logging.jar:/data/gump/jaka
rta-commons/logging/dist/commons-logging-api.jar"></property>
<property name="checkstyle.pattern.todo"
value="NOTHingWillMatCH_-"></property>
<property name="ant.version" value="Apache Ant version 1.7alpha compiled
on January 30 2004"></property>
<property name="build.clonevm" value="true"></property>
<property name="gump.merge"
value="/data/gump/gump/work/merge.xml"></property>
<property name="java.vm.specification.name" value="Java Virtual Machine
Specification"></property>
<property name="java.vm.specification.version" value="1.0"></property>
<property name="junit.jar" value="lib/junit.jar"></property>
<property name="sun.cpu.endian" value="little"></property>
<property name="sun.os.patch.level" value="unknown"></property>
<property name="java.awt.headless" value="true"></property>
<property name="clover.enable" value="false"></property>
<property name="java.io.tmpdir" value="/tmp"></property>
<property name="java.vendor.url.bug"
value="http://java.sun.com/cgi-bin/bugreport.cgi"></property>
<property name="os.arch" value="i386"></property>
<property name="java.awt.graphicsenv"
value="sun.awt.X11GraphicsEnvironment"></property>
<property name="java.ext.dirs"
value="/usr/java/j2sdk1.4.2/jre/lib/ext"></property>
<property name="regexp.jar"
value="lib/jakarta-regexp-1.3.jar"></property>
<property name="user.dir" value="/data/gump/checkstyle"></property>
<property name="translation.severity" value="ignore"></property>
<property name="testinputs.dir"
value="/data/gump/checkstyle/src/testinputs/com/puppycrawl/tools/checkstyle"
></property>
<property name="line.separator" value="
"></property>
<property name="java.vm.name" value="Java HotSpot(TM) Client
VM"></property>
<property name="checkstyle.grammar.dir"
value="src/checkstyle/com/puppycrawl/tools/checkstyle/grammars"></property>
<property name="have.xalan" value="true"></property>
<property name="basedir" value="/data/gump/checkstyle"></property>
<property name="ant.java.version" value="1.4"></property>
<property name="cli.jar" value="lib/commons-cli.jar"></property>
<property name="check.config"
value="/data/gump/checkstyle/docs/checkstyle_checks.xml"></property>
<property name="file.encoding" value="ANSI_X3.4-1968"></property>
<property name="antlr.jar" value="lib/antlr.jar"></property>
<property name="java.specification.version" value="1.4"></property>
<property name="testreport.dir" value="target/testreports"></property>
</properties>
<testcase name="testNoSuppressions"
classname="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
time="0.103">
<error message="unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_none.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error."
type="com.puppycrawl.tools.checkstyle.api.CheckstyleException">com.puppycraw
l.tools.checkstyle.api.CheckstyleException: unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_none.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error.
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:155)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:128)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testNoSuppres
sions(SuppressionsLoaderTest.java:18)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
Caused by: org.xml.sax.SAXParseException: Declared encoding
"UTF-8" does not match actual one "ASCII"; this might
not be an error.
at org.apache.crimson.parser.Parser2.warning(Parser2.java:3305)
at org.apache.crimson.parser.Parser2.readEncoding(Parser2.java:3103)
at org.apache.crimson.parser.Parser2.maybeXmlDecl(Parser2.java:1157)
at org.apache.crimson.parser.Parser2.parseInternal(Parser2.java:620)
at org.apache.crimson.parser.Parser2.parse(Parser2.java:333)
at org.apache.crimson.parser.XMLReaderImpl.parse(XMLReaderImpl.java:448)
at
com.puppycrawl.tools.checkstyle.api.AbstractLoader.parseInputSource(Abstract
Loader.java:83)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:145)
... 16 more
</error>
</testcase>
<testcase name="testMultipleSuppression"
classname="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
time="0.019">
<error message="unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_multiple.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error."
type="com.puppycrawl.tools.checkstyle.api.CheckstyleException">com.puppycraw
l.tools.checkstyle.api.CheckstyleException: unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_multiple.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error.
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:155)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:128)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testMultipleS
uppression(SuppressionsLoaderTest.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
Caused by: org.xml.sax.SAXParseException: Declared encoding
"UTF-8" does not match actual one "ASCII"; this might
not be an error.
at org.apache.crimson.parser.Parser2.warning(Parser2.java:3305)
at org.apache.crimson.parser.Parser2.readEncoding(Parser2.java:3103)
at org.apache.crimson.parser.Parser2.maybeXmlDecl(Parser2.java:1157)
at org.apache.crimson.parser.Parser2.parseInternal(Parser2.java:620)
at org.apache.crimson.parser.Parser2.parse(Parser2.java:333)
at org.apache.crimson.parser.XMLReaderImpl.parse(XMLReaderImpl.java:448)
at
com.puppycrawl.tools.checkstyle.api.AbstractLoader.parseInputSource(Abstract
Loader.java:83)
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoader.loadSuppressions(
SuppressionsLoader.java:145)
... 16 more
</error>
</testcase>
<testcase name="testNoFile"
classname="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
time="0.016">
<failure message="expected:<...Attribute "files" is
required and must be specified for element type "suppress"...>
but was:<...Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error...>"
type="junit.framework.ComparisonFailure">junit.framework.ComparisonFailure:
expected:<...Attribute "files" is required and must be
specified for element type "suppress"...> but
was:<...Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error...>
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testNoFile(Su
ppressionsLoaderTest.java:55)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
</failure>
</testcase>
<testcase name="testNoCheck"
classname="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
time="0.0060">
<failure message="expected:<...Attribute "checks" is
required and must be specified for element type "suppress"...>
but was:<...Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error...>"
type="junit.framework.ComparisonFailure">junit.framework.ComparisonFailure:
expected:<...Attribute "checks" is required and must be
specified for element type "suppress"...> but
was:<...Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error...>
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testNoCheck(S
uppressionsLoaderTest.java:69)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
</failure>
</testcase>
<testcase name="testBadInt"
classname="com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest"
time="0.0050">
<failure message="expected:<number format exception
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_bad_int.xml -
For input string: "a"> but was:<unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_bad_int.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error.>"
type="junit.framework.ComparisonFailure">junit.framework.ComparisonFailure:
expected:<number format exception
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_bad_int.xml -
For input string: "a"> but was:<unable to parse
src/testinputs/com/puppycrawl/tools/checkstyle/suppressions_bad_int.xml -
Declared encoding "UTF-8" does not match actual one
"ASCII"; this might not be an error.>
at
com.puppycrawl.tools.checkstyle.filters.SuppressionsLoaderTest.testBadInt(Su
ppressionsLoaderTest.java:83)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
</failure>
</testcase>
<system-out><![CDATA[]]></system-out>
<system-err><![CDATA[]]></system-err>
</testsuite>
Re: CheckStyle on Gump (again, again .. almost there...)
Posted by "Adam R. B. Jack" <aj...@trysybase.com>.
> 2) Do you think we ought split checkstyle into two projects, one for code,
> one for unit tests -- so the *many* folks who depend upon checkstyle still
> get Gumped even if a single unit test fails.
If somebody from checkstyle-dev can split the current gump take into three:
i.e.
<target name="gump"
depends="gump.setup,build.bindist,build.srcdist,run.tests"
description="Runs the test for GUMP testing"/>
into:
<target name="gump.build"
depends="gump.setup,build.bindist,build.srcdist,"
description="Build, for GUMP testing"/>
<target name="gump.test" depends="gump.setup,run.tests"
description="Run unit tests, for GUMP testing"/>
<target name="gump" depends="gump.setup,gump.build,gump.test"
description="Builds and Runs the test for GUMP testing"/>
I can work on creating two projects, 'checkstyle' and 'checkstyle-test' (the
latter of which depends upon the former) so folks can continue to gump even
if the odd test fails.
Do folks thing the above is correct? Looks correct to me (and outsider) but
I'm not sure of internal details...
> 3) Do you mind if we change the 'nag' emails to point to the
checkstyle-dev
> list?
Is that list the right one for the community around checkstyle?
regards,
Adam