You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/09/12 12:58:34 UTC
[jira] Created: (SOLR-2118) IndexReaderFactory.setTermIndexInterval
is misleading and confusing
IndexReaderFactory.setTermIndexInterval is misleading and confusing
-------------------------------------------------------------------
Key: SOLR-2118
URL: https://issues.apache.org/jira/browse/SOLR-2118
Project: Solr
Issue Type: Improvement
Components: search
Affects Versions: 1.4
Reporter: Robert Muir
Fix For: 3.1, 4.0
To change the terms index divisor: you currently do this:
{noformat}
<indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
<int name="setTermIndexInterval">12</int>
</indexReaderFactory >
{noformat}
But to change the terms index interval, you do this:
{noformat}
<indexDefaults>
...
<termIndexInterval>256</termIndexInterval>
...
</indexDefaults>
{noformat}
I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
the name is very misleading and someone could easily put a terrible value
in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2118) IndexReaderFactory.setTermIndexInterval
is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2118:
------------------------------
Issue Type: Bug (was: Improvement)
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908450#action_12908450 ]
Robert Muir commented on SOLR-2118:
-----------------------------------
bq. Setting the divisor that way shouldn't likely work on trunk anymore, since Lucene dropped it. That is just a generic 'call this bean method' system.
I am not referring to the IW parameter, but the IR param. The IR param is named termIndex *Interval* but is really the terms index *divisor*, this is what I feel is misleading and confusing.
just look at Solr's IndexReaderFactory to see:
{noformat}
Integer v = (Integer)args.get("setTermIndexInterval");
if (v != null) {
termInfosIndexDivisor = v.intValue();
}
{noformat}
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908445#action_12908445 ]
Mark Miller commented on SOLR-2118:
-----------------------------------
Setting the divisor that way shouldn't likely work on trunk anymore, since Lucene dropped it. That is just a generic 'call this bean method' system.
I think the story is that the interval came first, but we don't specify indexwriter anywhere in solrconfig, so it made sense to go where it is perhaps - and then later this generic system to call setters was impl'd, and it just happens that for a little while you could use it to set the termIndexInterval.
I'm all for consistency if it possible though. So far, Solr has really avoided exposing an IndexWriter - it's not even part of the UpdateHandler interface. We have hacked around that here and there by exposing in DirectUpdateHandler2 and counting on that impl for certain functionality.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908536#action_12908536 ]
Simon Willnauer commented on SOLR-2118:
---------------------------------------
bq. Seems like both the interval and the divisor could belong as properties of the index (i.e. the mainIndex section of solrconfig.xml)?
I agree, IMO we should try to keep TermIndexInterval and Divisor together both should be settable in the <indexDefaults> section
Additionally overriding those in a IndexReaderFactory section seems to be reasonable to me. question, is it possible to have more than one IR factory and use them in different places, I can't think of one from the top of my head since I never saw that param before?
If we enable setting IndexDivisor values in indexReaderFactory sections do we need to have the {{set}} prefix? <int name=:TermIndexDivisor">1</int> seems to be nicer or is this a set via reflection to a bean setter?
Regarding the patch, we should also change it in Example conf in {{solr/example/solr/conf/solrconfig.xml}} .
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908465#action_12908465 ]
Mark Miller commented on SOLR-2118:
-----------------------------------
Right, I get you now - I thought that was a typo in your examples.
I didn't realize that this triggers a method that someone put on the reader factory rather than trying to work with the indexreader.
So this is more a bug than an improvement.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908546#action_12908546 ]
Robert Muir commented on SOLR-2118:
-----------------------------------
{quote}
I agree, IMO we should try to keep TermIndexInterval and Divisor together both should be settable in the <indexDefaults> section
Additionally overriding those in a IndexReaderFactory section seems to be reasonable to me. question, is it possible to have more than one IR factory and use them in different places, I can't think of one from the top of my head since I never saw that param before?
If we enable setting IndexDivisor values in indexReaderFactory sections do we need to have the set prefix? <int name=:TermIndexDivisor">1</int> seems to be nicer or is this a set via reflection to a bean setter?
{quote}
I don't think we should change any of this under this issue, I agree with yonik its a bug.
I think it should simply be renamed back to divisor to match how it worked in Solr 1.4
{quote}
Regarding the patch, we should also change it in Example conf in solr/example/solr/conf/solrconfig.xml .
{quote}
Yes, i agree we should change the commented-out example there.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2118) IndexReaderFactory.setTermIndexInterval
is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2118:
------------------------------
Attachment: SOLR-2118.patch
mark you are right, so its not wrong in any release (we can just fix trunk/3x)
attached is a trivial patch
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908470#action_12908470 ]
Mark Miller commented on SOLR-2118:
-----------------------------------
I think I introduced this when upgrading to Solr to Lucene 3 on a different branch back in the day - a quick fix that was wrong or something.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved SOLR-2118.
-------------------------------
Resolution: Fixed
Committed 996416, 996417 (3x)
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch, SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2118) IndexReaderFactory.setTermIndexInterval
is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2118:
------------------------------
Affects Version/s: 3.1
4.0
(was: 1.4)
fixing affects version, 1.4 is ok, its 3.1 and 4.0 that have the problem.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (SOLR-2118)
IndexReaderFactory.setTermIndexInterval is misleading and confusing
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908469#action_12908469 ]
Yonik Seeley commented on SOLR-2118:
------------------------------------
Yeah, definitely a bug.
Seems like both the interval and the divisor could belong as properties of the index (i.e. the mainIndex section of solrconfig.xml)?
The current index reader factory architecture may not go where we need to go anyway actually... for NRT, the writer(s) need to be involved? Sort of outside of the scope of an immediate fix for this issue - but something to think about.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 1.4
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (SOLR-2118) IndexReaderFactory.setTermIndexInterval
is misleading and confusing
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated SOLR-2118:
------------------------------
Attachment: SOLR-2118.patch
attached is a patch, with all examples and other solrconfigs in test-files set back to setTermIndexDivisor as it was in Solr 1.4
I think this is important, if someone depends on this currently in 1.4 and tries out 3.x or trunk, they might get OOM since it wont be respected.
So, i'd like to commit this at the end of the day if there are no objections.
Separately, i agree it would be better if this sat with the other related index variables in the solrconfig, but I think thats for another issue.
> IndexReaderFactory.setTermIndexInterval is misleading and confusing
> -------------------------------------------------------------------
>
> Key: SOLR-2118
> URL: https://issues.apache.org/jira/browse/SOLR-2118
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: SOLR-2118.patch, SOLR-2118.patch
>
>
> To change the terms index divisor: you currently do this:
> {noformat}
> <indexReaderFactory name="IndexReaderFactory" class="org.apache.solr.core.StandardIndexReaderFactory">
> <int name="setTermIndexInterval">12</int>
> </indexReaderFactory >
> {noformat}
> But to change the terms index interval, you do this:
> {noformat}
> <indexDefaults>
> ...
> <termIndexInterval>256</termIndexInterval>
> ...
> </indexDefaults>
> {noformat}
> I feel the IR parameter should be *setTermIndexDivisor* or similar instead:
> the name is very misleading and someone could easily put a terrible value
> in the wrong place by confusing the two.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org