You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/25 07:49:55 UTC
[GitHub] [skywalking] Yolo-Hao opened a new issue #7170: missing db.statement tag for jedis blocking api
Yolo-Hao opened a new issue #7170:
URL: https://github.com/apache/skywalking/issues/7170
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [x] Question or discussion
- [x] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Bug
- Which version of SkyWalking, OS, and JRE?
SkyWalking latest
- What happened?
when using jedis blocking api like `blpop`，it won't have a `db.statement` tag, because it only check type `String` and `byte[]` for first argument as below:
```java
if (allArguments.length > 0 && allArguments[0] instanceof String) {
Tags.DB_STATEMENT.set(span, method.getName() + " " + allArguments[0]);
} else if (allArguments.length > 0 && allArguments[0] instanceof byte[]) {
Tags.DB_STATEMENT.set(span, method.getName());
}
```
maybe we need to add a check for `Integer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7170: missing db.statement tag for jedis blocking api
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7170:
URL: https://github.com/apache/skywalking/issues/7170#issuecomment-870203836
Closing due to author's comments, https://github.com/apache/skywalking/pull/7185#issuecomment-870201002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7170: missing db.statement tag for jedis blocking api
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7170:
URL: https://github.com/apache/skywalking/issues/7170#issuecomment-868355178
Feel free to enhance plugin, you could send a pull request. Also, you need to enhancr plugin integration test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7170: missing db.statement tag for jedis blocking api
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7170:
URL: https://github.com/apache/skywalking/issues/7170#issuecomment-870203836
Closing due to author's comments, https://github.com/apache/skywalking/pull/7185#issuecomment-870201002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7170: missing db.statement tag for jedis blocking api
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7170:
URL: https://github.com/apache/skywalking/issues/7170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #7170: missing db.statement tag for jedis blocking api
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7170:
URL: https://github.com/apache/skywalking/issues/7170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org