[GitHub] [geode] Bill opened pull request #2462: GEODE-5732: Remove TxCommitMessageTest

["Bill (GitHub)" <gi...@apache.org>]

After recent move to Mockito, we found that this test doesn't fail when
we break the corresponding product code e.g. changing hasFlagsField() to
always return true should break tests but doesn't.

We verified that the test named like TxCommitMessageBC* do a better job
of checking serialization of TxCommitMessage between product versions.

Co-authored-by: Dan Smith <ds...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2462 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout closed pull request #2462: GEODE-5732: Remove TxCommitMessageTest

["upthewaterspout (GitHub)" <gi...@apache.org>]

[ pull request closed by upthewaterspout ]

[ Full content available at: https://github.com/apache/geode/pull/2462 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #2462: GEODE-5732: Remove TxCommitMessageTest

["Bill (GitHub)" <gi...@apache.org>]

@pivotal-jbarrett @nabarunnag @upthewaterspout

[ Full content available at: https://github.com/apache/geode/pull/2462 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org