You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/08 04:15:16 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #37827: [SPARK-40383][INFRA] Pin mypy ==0.920 in dev/requirements.txt
zhengruifeng opened a new pull request, #37827:
URL: https://github.com/apache/spark/pull/37827
### What changes were proposed in this pull request?
Pin mypy ==0.920 in dev/requirements.txt, the same as that in `.github/workflows/build_and_test.yml`
### Why are the changes needed?
before:
the installed version of mypy is `mypy 0.971` now, the `python-lint` always fail:
```
(spark_dev) ➜ spark git:(master) ✗ dev/lint-python
starting python compilation test...
python compilation succeeded.
starting black test...
black checks passed.
starting flake8 test...
flake8 checks passed.
starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/streaming/context.py:372: error: Unused "type: ignore" comment
python/pyspark/streaming/context.py:378: error: Unused "type: ignore" comment
Found 2 errors in 1 file (checked 339 source files)
1
```
after:
```
(spark_dev) ➜ spark git:(master) ✗ dev/lint-python
starting python compilation test...
python compilation succeeded.
starting black test...
black checks passed.
starting flake8 test...
flake8 checks passed.
starting mypy annotations test...
annotations passed mypy checks.
starting mypy examples test...
examples passed mypy checks.
starting mypy data test...
annotations passed data checks.
all lint-python tests passed!
```
### Does this PR introduce _any_ user-facing change?
No, only for spark contributors.
### How was this patch tested?
manually test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #37827: [SPARK-40383][INFRA] Pin `mypy==0.920` in dev/requirements.txt
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #37827: [SPARK-40383][INFRA] Pin `mypy==0.920` in dev/requirements.txt
URL: https://github.com/apache/spark/pull/37827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37827: [SPARK-40383][INFRA] Pin `mypy==0.920` in dev/requirements.txt
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37827:
URL: https://github.com/apache/spark/pull/37827#issuecomment-1240612611
@itholic @HyukjinKwon @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #37827: [SPARK-40383][INFRA] Pin `mypy==0.920` in dev/requirements.txt
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #37827:
URL: https://github.com/apache/spark/pull/37827#issuecomment-1241359390
Merged into master, thank you @Yikun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #37827: [SPARK-40383][INFRA] Pin `mypy==0.920` in dev/requirements.txt
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #37827:
URL: https://github.com/apache/spark/pull/37827#issuecomment-1244825022
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org