[GitHub] [cloudstack] shwstppr commented on a change in pull request #3293: Limit selecting of secondary storage with 90% utilization

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #3293: Limit selecting of secondary storage with 90% utilization
URL: https://github.com/apache/cloudstack/pull/3293#discussion_r288480631
 
 

 ##########
 File path: engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/manager/ImageStoreProviderManagerImpl.java
 ##########
 @@ -157,6 +157,7 @@ public DataStore getImageStore(List<DataStore> imageStores) {
                 }
             }
         }
-        return imageStores.get(0);
+        s_logger.debug("Can't find staging storage in zone with less than 90% usage");
 
 Review comment:
   @kioie 90% cutoff value is defined here https://github.com/apache/cloudstack/blob/7e4a300a216a31348d2adbcc641d26e8339da205/server/src/main/java/com/cloud/server/StatsCollector.java#L290 and it can change in the future. Would it be better to not use constant in logs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services