You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/31 06:37:15 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #32704: [SPARK-35567][SQL] Fix: Explain cost is not showing statistics for all the nodes
cloud-fan commented on a change in pull request #32704:
URL: https://github.com/apache/spark/pull/32704#discussion_r642244548
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -256,13 +255,9 @@ class QueryExecution(
// trigger to compute stats for logical plans
try {
- optimizedPlan.foreach(_.expressions.foreach(_.foreach {
Review comment:
how about
```
// trigger subquery's child plan stats propagation
optimizedPlan.subqueriesAll.foreah(_.stats)
optimizedPlan.stats
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org