You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/10 14:52:50 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #180:
SUBMARINE-379. Delete invalid .gitmodules file
liuxunorg opened a new pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180
### What is this PR for?
Deleted the tony submodule in https://issues.apache.org/jira/browse/SUBMARINE-371, but forgot to delete the .gitmodules file and configure in pom.xml.
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-379
### How should this be tested?
* https://travis-ci.org/liuxunorg/submarine/builds/648431616
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #180: SUBMARINE-379. Delete
invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#issuecomment-584189319
+1 LGTM. Thanks @liuxunorg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #180:
SUBMARINE-379. Delete invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#discussion_r377483473
##########
File path: pom.xml
##########
@@ -441,10 +441,6 @@
<goals>
<goal>check</goal>
</goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
Review comment:
Do we need to delete this line? line 428 is like <failOnViolation>false</failOnViolation>.
How about we just delete <excludes>com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/*</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #180:
SUBMARINE-379. Delete invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#discussion_r377483473
##########
File path: pom.xml
##########
@@ -441,10 +441,6 @@
<goals>
<goal>check</goal>
</goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
Review comment:
Do we need to delete this line? line 428 is to set failOnViolation to false.
How about we just delete <excludes>com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/*</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #180: SUBMARINE-379. Delete
invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #180:
SUBMARINE-379. Delete invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#discussion_r377483473
##########
File path: pom.xml
##########
@@ -441,10 +441,6 @@
<goals>
<goal>check</goal>
</goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
Review comment:
Do we need to delete this line? line 428 is like "<failOnViolation>false</failOnViolation>".
How about we just delete <excludes>com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/*</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #180: SUBMARINE-379.
Delete invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#issuecomment-585047511
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #180:
SUBMARINE-379. Delete invalid .gitmodules file
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #180: SUBMARINE-379. Delete invalid .gitmodules file
URL: https://github.com/apache/submarine/pull/180#discussion_r377483473
##########
File path: pom.xml
##########
@@ -441,10 +441,6 @@
<goals>
<goal>check</goal>
</goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
Review comment:
Do we need to delete this line? line 428 is like to set failOnViolation to false.
How about we just delete <excludes>com/linkedin/tony/rpc/proto/*,com/linkedin/tony/events/*</excludes>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org