You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/12/02 18:33:29 UTC
Re: Review Request 15169: Expose git sha and branch in master and slave
state.json
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15169/#review29596
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/15169/#comment56991>
Minor nit, but what about s/GIT_SHA_FLAG/BUILD_GIT_SHA/ as well as for the ones below?
- Benjamin Hindman
On Nov. 27, 2013, 4:56 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15169/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 4:56 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Exposing build revisions and branch names can help diagnosing problems with slaves and masters in development settings.
>
> This patch fetches git sha and branch of repo (if available) and fills option variables BUILD_GIT_SHA and BUILD_GIT_BRANCH accordingly.
> If variables are set, master and slave state.json expose and sets fields "git_sha" and "git_branch".
>
>
> Diffs
> -----
>
> configure.ac ba4ec1d
> src/Makefile.am abef3d2
> src/common/build.hpp c0e2a64
> src/common/build.cpp 960b017
> src/master/http.cpp 218906a
> src/slave/http.cpp fbc917b
>
> Diff: https://reviews.apache.org/r/15169/diff/
>
>
> Testing
> -------
>
> make check
>
> Functional testing of:
> 1) Development version (from git repo) -> Shows correct git hash and branch
> 2) Distribution version (from make dist) -> Does *not* show git hash and branch fields in state.json
>
>
> Thanks,
>
> Niklas Nielsen
>
>