You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/06/05 23:13:13 UTC
Review Request 35119: Introduced metrics for revocable resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35119/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2776
https://issues.apache.org/jira/browse/MESOS-2776
Repository: mesos
Description
-------
state.json changes are in a subsequent review.
Diffs
-----
src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f
src/master/master.cpp be0db42da3c59761aa154439653d715556465256
src/master/metrics.hpp 833033c1912daee429b45423d24d365d8699a428
src/master/metrics.cpp 264252c5159990fdf7a4569933a305d07bd7dd6e
src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
Diff: https://reviews.apache.org/r/35119/diff/
Testing
-------
make check.
- Modified a test to test the `total` resources metrics.
- We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too.
Thanks,
Jiang Yan Xu
Re: Review Request 35119: Introduced metrics for revocable resources.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35119/
-----------------------------------------------------------
(Updated June 7, 2015, 1:32 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Vinod's comments.
Bugs: MESOS-2776
https://issues.apache.org/jira/browse/MESOS-2776
Repository: mesos
Description
-------
state.json changes are in a subsequent review.
Diffs (updated)
-----
src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f
src/master/master.cpp d436f845341ca33a534127da3bad8d8b2aa1175b
src/master/metrics.hpp 833033c1912daee429b45423d24d365d8699a428
src/master/metrics.cpp 264252c5159990fdf7a4569933a305d07bd7dd6e
src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
Diff: https://reviews.apache.org/r/35119/diff/
Testing
-------
make check.
- Modified a test to test the `total` resources metrics.
- We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too.
Thanks,
Jiang Yan Xu
Re: Review Request 35119: Introduced metrics for revocable resources.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35119/#review86851
-----------------------------------------------------------
Ship it!
src/master/metrics.hpp
<https://reviews.apache.org/r/35119/#comment138952>
s/irrevocable/non-revocable/
src/master/metrics.cpp
<https://reviews.apache.org/r/35119/#comment138953>
ditto.
- Vinod Kone
On June 5, 2015, 9:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35119/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 9:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2776
> https://issues.apache.org/jira/browse/MESOS-2776
>
>
> Repository: mesos
>
>
> Description
> -------
>
> state.json changes are in a subsequent review.
>
>
> Diffs
> -----
>
> src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/master/metrics.hpp 833033c1912daee429b45423d24d365d8699a428
> src/master/metrics.cpp 264252c5159990fdf7a4569933a305d07bd7dd6e
> src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
>
> Diff: https://reviews.apache.org/r/35119/diff/
>
>
> Testing
> -------
>
> make check.
>
> - Modified a test to test the `total` resources metrics.
> - We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 35119: Introduced metrics for revocable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35119/#review86853
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35118, 35119]
All tests passed.
- Mesos ReviewBot
On June 5, 2015, 9:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35119/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 9:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2776
> https://issues.apache.org/jira/browse/MESOS-2776
>
>
> Repository: mesos
>
>
> Description
> -------
>
> state.json changes are in a subsequent review.
>
>
> Diffs
> -----
>
> src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f
> src/master/master.cpp be0db42da3c59761aa154439653d715556465256
> src/master/metrics.hpp 833033c1912daee429b45423d24d365d8699a428
> src/master/metrics.cpp 264252c5159990fdf7a4569933a305d07bd7dd6e
> src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7
>
> Diff: https://reviews.apache.org/r/35119/diff/
>
>
> Testing
> -------
>
> make check.
>
> - Modified a test to test the `total` resources metrics.
> - We don't have unit tests that use the revocable resources yet, when we add that we should check `used` resources metrics too.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>