[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #232: Simplify how we show text differences when a TDML test fails
URL: https://github.com/apache/incubator-daffodil/pull/232#discussion_r292926360
 
 

 ##########
 File path: daffodil-lib/src/main/scala/org/apache/daffodil/xml/XMLUtils.scala
 ##########
 @@ -748,16 +748,13 @@ object XMLUtils {
 Comparison failed.
 Expected (attributes stripped)
           %s
-Actual (attributes stripped)
+Actual (attributes ignored for diff)
 
 Review comment:
   I'm not sure if we have an explicit test for the XMLUtils xml comparison logic to make sure we can find xsi:nil differences. However, I have modified a nillable test to remove ``xsi:nil="true"`` from the expected infoset and got an error saying the expected infoset did not have the attribute, so I think our xsi:nil checking logic is correct. It's very possible that there's a edgecase or a bug somewhere, but the expected cases look correct to me. Attributes are ignored, but we special case and xsi:nil as expected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services