You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/06/13 17:16:00 UTC
[jira] [Commented] (IMPALA-11314) Add automated tests for PyPi impala-shell to precommit
[ https://issues.apache.org/jira/browse/IMPALA-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553721#comment-17553721 ]
ASF subversion and git services commented on IMPALA-11314:
----------------------------------------------------------
Commit 5263d13112bc35ae69e2c2c09adc823a96fc8c13 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=5263d1311 ]
IMPALA-11314: Test PyPI package with system python
Sets up a virtualenv with system python to install the impala-shell PyPI
package into. Using system python provides better coverage for Python
versions likely to be used by customers. Runs impala-shell tests using
the PyPI package to provide better coverage for the artifact customers
will use.
Includes a PyPI install in notests_independent_targets because these
seem to be used for Python testing despite -notests.
Change-Id: I384ea6a7dab51945828cca629860400a23fa0c05
Reviewed-on: http://gerrit.cloudera.org:8080/18586
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
> Add automated tests for PyPi impala-shell to precommit
> ------------------------------------------------------
>
> Key: IMPALA-11314
> URL: https://issues.apache.org/jira/browse/IMPALA-11314
> Project: IMPALA
> Issue Type: Improvement
> Components: Clients
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Michael Smith
> Priority: Major
>
> The PyPi form factor of impala-shell is becoming more important, and we need to have more consistent testing of that form factor. We should run the shell tests with a PyPi-installed impala-shell in addition to the traditional impala-shell form factor. One way to do that would be to have the CMake build produce a virtualenv and install impala-shell into it. The impala-shell executable would be at a known location, and add a test dimension for the extra shell type.
> This form factor also makes it easy to use Python 3, as that is another major dimension that needs testing.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org