[jira] [Commented] (FLUME-936) MemoryChannel is not thread safe

["Juhani Connolly (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197422#comment-13197422 ] 

Juhani Connolly commented on FLUME-936:
---------------------------------------

Blocking on 935 makes total sense to me, and as I mentioned there, there was still a couple of things I was concerned in in that. Once that is settled, I will fix up any details left. I'll put together another unit test today.

I'm also including in the fixes I made to flume-889 before(that issue can be cancelled as far as I'm concerned), the ones that prevented data loss on reconfiguration
                
> MemoryChannel is not thread safe
> --------------------------------
>
>                 Key: FLUME-936
>                 URL: https://issues.apache.org/jira/browse/FLUME-936
>             Project: Flume
>          Issue Type: Bug
>          Components: Channel
>    Affects Versions: NG alpha 2
>            Reporter: Juhani Connolly
>            Assignee: Juhani Connolly
>             Fix For: v1.1.0
>
>         Attachments: FLUME-936-unittest.patch
>
>
> The memory channel isn't thread safe as a couple of parallel transactions can commit/rollback each others entries if called in the wrong order.
> I'm attaching a unit test I made that demonstrates it using a cyclicbarrier to force the event order that causes the precondition to fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira