[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24683: [SPARK-20547][REPL]Throw RemoteClassLoadedError for transient errors in ExecutorClassLoader

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24683: [SPARK-20547][REPL]Throw RemoteClassLoadedError for transient errors in ExecutorClassLoader
URL: https://github.com/apache/spark/pull/24683#discussion_r287003969
 
 

 ##########
 File path: repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala
 ##########
 @@ -237,3 +262,11 @@ extends ClassVisitor(ASM7, cv) {
     }
   }
 }
+
+/**
+ * An error when we cannot load a class due to exceptions. We don't know if this class exists, so
+ * throw a special one that's not [[LinkageError]] nor [[ClassNotFoundException]] to make JVM retry
 
 Review comment:
   Nit: `neither [[LinkageError]] nor`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org