You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by ch...@apache.org on 2010/04/22 00:07:14 UTC
svn commit: r936538 -
/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
Author: chirag
Date: Wed Apr 21 22:07:14 2010
New Revision: 936538
URL: http://svn.apache.org/viewvc?rev=936538&view=rev
Log:
Prevent duplicate ampersand from being appended inside OAuthRequest.
Code Review: http://codereview.appspot.com/906046/show
Modified:
shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java?rev=936538&r1=936537&r2=936538&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java Wed Apr 21 22:07:14 2010
@@ -609,7 +609,15 @@ public class OAuthRequest {
if (result.getPostBodyLength() == 0) {
result.setPostBody(CharsetUtil.getUtf8Bytes(oauthData));
} else {
- result.setPostBody((result.getPostBodyAsString() + '&' + oauthData).getBytes());
+ StringBuilder postBody = new StringBuilder();
+ postBody.append(result.getPostBodyAsString());
+
+ if (!result.getPostBodyAsString().endsWith("&")) {
+ postBody.append('&');
+ }
+
+ postBody.append(oauthData);
+ result.setPostBody(postBody.toString().getBytes());
}
break;