You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/17 23:08:26 UTC

[GitHub] [iceberg] amogh-jahagirdar commented on pull request #5555: Add s3.acceleration-enbled flag to AwsProperties

amogh-jahagirdar commented on PR #5555:
URL: https://github.com/apache/iceberg/pull/5555#issuecomment-1218605037

   This is great! Overall LGTM but I think we should integrate this to all the AwsClientFactory implementations provided by Iceberg.  
   
   https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/lakeformation/LakeFormationAwsClientFactory.java 
   
   and 
   
   https://github.com/apache/iceberg/blob/master/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org