You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/13 02:38:23 UTC
[GitHub] [pulsar] maxsxu opened a new pull request, #16027: [feat][workflow] Upgrade to new version of documentation bot
maxsxu opened a new pull request, #16027:
URL: https://github.com/apache/pulsar/pull/16027
Master Issue: #15797
### Motivation
We have implemented the new documentation bot at https://github.com/apache/pulsar-test-infra/pull/43.
Now we can apply it to our workflow.
### Modifications
Replace the old action with the new version of documentation bot.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16027:
URL: https://github.com/apache/pulsar/pull/16027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#discussion_r895743756
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -17,33 +17,37 @@
# under the License.
#
-name: Auto Labeling
+name: Documentation Bot
on:
pull_request_target :
types:
- opened
- edited
- labeled
-
-
-
-# A GitHub token created for a PR coming from a fork doesn't have
-# 'admin' or 'write' permission (which is required to add labels)
-# To avoid this issue, you can use the `scheduled` event and run
-# this action on a certain interval.And check the label about the
-# document.
+ - unlabeled
jobs:
- labeling:
+ label:
if: ${{ github.repository == 'apache/pulsar' }}
permissions:
pull-requests: write
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - name: Checkout action
+ uses: actions/checkout@v3
+ with:
+ repository: apache/pulsar-test-infra/docbot
+ ref: master
- - uses: apache/pulsar-test-infra/doc-label-check@master
+ - name: Set up Go
+ uses: actions/setup-go@v3
with:
- github-token: ${{ secrets.GITHUB_TOKEN }}
- label-pattern: '- \[(.*?)\] ?`(.+?)`' # matches '- [x] `label`'
+ go-version: 1.18
Review Comment:
got it, the action is a composite job so it needs it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#issuecomment-1153925669
This seems to break the jobs. `Invalid repository 'apache/pulsar-test-infra/docbot'. Expected format {owner}/{repo}.` is the error message. @maxsxu did you test that this change works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#discussion_r895727512
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -17,33 +17,37 @@
# under the License.
#
-name: Auto Labeling
+name: Documentation Bot
on:
pull_request_target :
types:
- opened
- edited
- labeled
-
-
-
-# A GitHub token created for a PR coming from a fork doesn't have
-# 'admin' or 'write' permission (which is required to add labels)
-# To avoid this issue, you can use the `scheduled` event and run
-# this action on a certain interval.And check the label about the
-# document.
+ - unlabeled
jobs:
- labeling:
+ label:
if: ${{ github.repository == 'apache/pulsar' }}
permissions:
pull-requests: write
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - name: Checkout action
+ uses: actions/checkout@v3
+ with:
+ repository: apache/pulsar-test-infra/docbot
+ ref: master
- - uses: apache/pulsar-test-infra/doc-label-check@master
+ - name: Set up Go
+ uses: actions/setup-go@v3
with:
- github-token: ${{ secrets.GITHUB_TOKEN }}
- label-pattern: '- \[(.*?)\] ?`(.+?)`' # matches '- [x] `label`'
+ go-version: 1.18
Review Comment:
why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#issuecomment-1153937658
@Anonymitaet How was this tested? All jobs fail after this was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a diff in pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#discussion_r895726873
##########
.github/workflows/ci-documentbot.yml:
##########
@@ -17,33 +17,37 @@
# under the License.
#
-name: Auto Labeling
+name: Documentation Bot
on:
pull_request_target :
types:
- opened
- edited
- labeled
-
-
-
-# A GitHub token created for a PR coming from a fork doesn't have
-# 'admin' or 'write' permission (which is required to add labels)
-# To avoid this issue, you can use the `scheduled` event and run
-# this action on a certain interval.And check the label about the
-# document.
+ - unlabeled
jobs:
- labeling:
+ label:
if: ${{ github.repository == 'apache/pulsar' }}
permissions:
pull-requests: write
runs-on: ubuntu-latest
steps:
- - uses: actions/checkout@v2
+ - name: Checkout action
+ uses: actions/checkout@v3
+ with:
+ repository: apache/pulsar-test-infra/docbot
+ ref: master
Review Comment:
this doesn't make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16027: [feat][workflow] Upgrade to new version of documentation bot
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16027:
URL: https://github.com/apache/pulsar/pull/16027#issuecomment-1153470412
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org