You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/24 19:11:04 UTC

[GitHub] [kafka] joshuagrisham commented on pull request #9493: KAFKA-10640: Add recursive support to Connect Cast and ReplaceField transforms, and support for casting complex types to either a native or JSON string.

joshuagrisham commented on pull request #9493:
URL: https://github.com/apache/kafka/pull/9493#issuecomment-716041356


   I cleaned up most of the checkstyle issues before creating this new PR but it is still failing in 3 places due to CyclomaticComplexity failure.  This is basically because the code is recursive and everything has been set up in "pieces" that can be called recursively so sort of through design it can recurs quite deeply into different methods.  
   So to get past this check, unfortunately I will need to refactor it a bit, to consolidate some of the functionality into larger methods or figure out a slightly different solution. 
   Unless anyone else has a better idea... ? 😸 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org