You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@gmail.com> on 2017/03/07 00:50:02 UTC
Review Request 57351: [ATLAS-1648] : Fix HiveHookIT failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57351/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1648
https://issues.apache.org/jira/browse/ATLAS-1648
Repository: atlas
Description
-------
Fixed failures in:
Failed tests:
HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata servic...
HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 Assertions failed. Failing after waiting for timeout 80000 msecs
HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata s...
HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService
Diffs
-----
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java dce55c4
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java d640a81
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java f8083de
Diff: https://reviews.apache.org/r/57351/diff/1/
Testing
-------
Failed ITs run successfully.
Thanks,
Sarath Subramanian
Re: Review Request 57351: [ATLAS-1648] : Fix HiveHookIT failures
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57351/#review168187
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java
Lines 104 (patched)
<https://reviews.apache.org/r/57351/#comment240353>
isAllUnassignedAttrs() - name is a little difficult to read. Consider renaming to something like hasAnyAssignedAttribute()
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java
Lines 107 (patched)
<https://reviews.apache.org/r/57351/#comment240352>
rInstance.getId().isAssigned() - this condition doesn't seem necessary.
- Madhan Neethiraj
On March 7, 2017, 7:05 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57351/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 7:05 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1648
> https://issues.apache.org/jira/browse/ATLAS-1648
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fixed failures in:
> Failed tests:
> HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata servic...
> HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 Assertions failed. Failing after waiting for timeout 80000 msecs
> HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata s...
> HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java d640a81
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java f8083de
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
>
>
> Diff: https://reviews.apache.org/r/57351/diff/2/
>
>
> Testing
> -------
>
> Failed ITs run successfully.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 57351: [ATLAS-1648] : Fix HiveHookIT failures
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57351/#review168205
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 7, 2017, 10:08 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57351/
> -----------------------------------------------------------
>
> (Updated March 7, 2017, 10:08 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
>
>
> Bugs: ATLAS-1648
> https://issues.apache.org/jira/browse/ATLAS-1648
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fixed failures in:
> Failed tests:
> HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata servic...
> HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 Assertions failed. Failing after waiting for timeout 80000 msecs
> HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata s...
> HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService
>
>
> Diffs
> -----
>
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java d640a81
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java f8083de
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 91e2947
>
>
> Diff: https://reviews.apache.org/r/57351/diff/3/
>
>
> Testing
> -------
>
> Failed ITs run successfully.
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 57351: [ATLAS-1648] : Fix HiveHookIT failures
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57351/
-----------------------------------------------------------
(Updated March 7, 2017, 2:08 p.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1648
https://issues.apache.org/jira/browse/ATLAS-1648
Repository: atlas
Description
-------
Fixed failures in:
Failed tests:
HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata servic...
HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 Assertions failed. Failing after waiting for timeout 80000 msecs
HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata s...
HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService
Diffs (updated)
-----
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java d640a81
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java f8083de
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 91e2947
Diff: https://reviews.apache.org/r/57351/diff/3/
Changes: https://reviews.apache.org/r/57351/diff/2-3/
Testing
-------
Failed ITs run successfully.
Thanks,
Sarath Subramanian
Re: Review Request 57351: [ATLAS-1648] : Fix HiveHookIT failures
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57351/
-----------------------------------------------------------
(Updated March 7, 2017, 11:05 a.m.)
Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Suma Shivaprasad, and Vimal Sharma.
Bugs: ATLAS-1648
https://issues.apache.org/jira/browse/ATLAS-1648
Repository: atlas
Description
-------
Fixed failures in:
Failed tests:
HiveMetastoreBridgeIT.testImportCreatedTable:79 » AtlasService Metadata servic...
HiveHookIT.testAlterTablePartitionColumnType:1216->assertColumnIsRegistered:283->HiveITBase.assertEntityIsRegistered:158->HiveITBase.waitFor:202 Assertions failed. Failing after waiting for timeout 80000 msecs
HiveHookIT.testAlterTableRename:889->createTrait:946 » AtlasService Metadata s...
HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService
Diffs (updated)
-----
addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java d640a81
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java f8083de
repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5ab8d7
Diff: https://reviews.apache.org/r/57351/diff/2/
Changes: https://reviews.apache.org/r/57351/diff/1-2/
Testing
-------
Failed ITs run successfully.
Thanks,
Sarath Subramanian