You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2017/09/13 23:30:04 UTC
Review Request 62313: RANGER-1647: Allow Ranger policy conditions to
use tag attributes and values in Ranger -- ranger0.7 branch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62313/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1647
https://issues.apache.org/jira/browse/RANGER-1647
Repository: ranger
Description
-------
Merged https://reviews.apache.org/r/60140/ to ranger-0.7 branch and added patch file to handle upgrades.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java 48ffc38
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java acd96be
agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json 3bad222
agents-common/src/test/resources/policyengine/resourceTags.json 9523ca0
agents-common/src/test/resources/policyengine/test_policyengine_owner.json 82a6632
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 04b9afe
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json c2cb0b3
Diff: https://reviews.apache.org/r/62313/diff/1/
Testing
-------
1. Performed basic functionality tests
2. Ran all the unit tests with successfully.
Thanks,
Sailaja Polavarapu
Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions
to use tag attributes and values in Ranger -- ranger0.7 branch
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62313/#review185416
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On Sept. 13, 2017, 11:33 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62313/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 11:33 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1647
> https://issues.apache.org/jira/browse/RANGER-1647
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Merged https://reviews.apache.org/r/60140/ to ranger-0.7 branch and added patch file to handle upgrades.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62313/diff/2/
>
>
> Testing
> -------
>
> 1. Performed basic functionality tests
> 2. Ran all the unit tests with successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions
to use tag attributes and values in Ranger -- ranger0.7 branch
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62313/#review185455
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java
Lines 165 (patched)
<https://reviews.apache.org/r/62313/#comment261750>
Please review this logic. It appears that preUpdateValue will always be null. Should the line 164 be as follows?
if(serviceDefOptionsPreUpdate == null || serviceDefOptionsPreUpdate.containsKey(RangerServiceDef.OPTION_ENABLE_DENY_AND_EXCEPTIONS_IN_POLICIES)) {
I think the idea is that the value of RangerServiceDef.OPTION_ENABLE_DENY_AND_EXCEPTIONS_IN_POLICIES before the updateServiceDef needs to be restored in the database if the updateServiceDef() call (line 154) causes the value of the option to be overwritten.
- Abhay Kulkarni
On Sept. 13, 2017, 11:33 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62313/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 11:33 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1647
> https://issues.apache.org/jira/browse/RANGER-1647
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Merged https://reviews.apache.org/r/60140/ to ranger-0.7 branch and added patch file to handle upgrades.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62313/diff/2/
>
>
> Testing
> -------
>
> 1. Performed basic functionality tests
> 2. Ran all the unit tests with successfully.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 62313: RANGER-1647: Allow Ranger policy conditions
to use tag attributes and values in Ranger -- ranger0.7 branch
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62313/
-----------------------------------------------------------
(Updated Sept. 13, 2017, 11:33 p.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Missed upgrade patch file
Bugs: RANGER-1647
https://issues.apache.org/jira/browse/RANGER-1647
Repository: ranger
Description
-------
Merged https://reviews.apache.org/r/60140/ to ranger-0.7 branch and added patch file to handle upgrades.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java PRE-CREATION
Diff: https://reviews.apache.org/r/62313/diff/2/
Changes: https://reviews.apache.org/r/62313/diff/1-2/
Testing
-------
1. Performed basic functionality tests
2. Ran all the unit tests with successfully.
Thanks,
Sailaja Polavarapu