You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 09:30:36 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4739: Allow creating snapshot from VM snapshot
ravening opened a new pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739
### Description
If `kvm.snapshot.enabled` is set to false then we cant create snapshot from
VM snapshot. With this change, its possible to create snapshot from VM
snapshot even when the global setting is set to false.
Note that you still cant directly create a snapshot from volume though
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-820232690
> Re-ping @ravening
@rhtyd will look into it in few days.. kind of busy with some other work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-810788000
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#discussion_r615792850
##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1049,7 +1049,7 @@ private Type getSnapshotType(IntervalType intvType) {
return null;
}
- private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume) {
+ private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume, boolean isFromVmSnapshot) {
Review comment:
can you correct the type error in method name
```suggestion
private boolean hostSupportsSnapshotForVolume(HostVO host, VolumeInfo volume, boolean isFromVmSnapshot) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#discussion_r615791884
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -2692,7 +2692,7 @@ public Snapshot allocSnapshot(Long volumeId, Long policyId, String snapshotName,
throw new InvalidParameterValueException("VolumeId: " + volumeId + " please attach this volume to a VM before create snapshot for it");
}
- return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType);
+ return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType, null);
Review comment:
@ravening null here means true or false ? if false, you can keep the old method.
```suggestion
return snapshotMgr.allocSnapshot(volumeId, policyId, snapshotName, locationType, null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-810756670
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888912908
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-836644981
Ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-821092212
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-889536969
<b>Trillian test result (tid-1405)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52774 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4739-t1405-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 88 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3603.54 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3606.89 | test_kubernetes_clusters.py
test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 87.86 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-924369961
<b>Trillian test result (tid-2147)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39298 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4739-t2147-kvm-centos7.zip
Smoke tests completed. 84 look OK, 5 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.61 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.21 | test_primary_storage.py
test_01_secure_vm_migration | `Error` | 164.38 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 274.29 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 146.94 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 43.72 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 1.18 | test_snapshots.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 30.92 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 67.74 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 61.81 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 81.58 | test_kubernetes_clusters.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 304.89 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-805747260
@weizhouapache @ravening any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-923800624
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on a change in pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on a change in pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#discussion_r678917771
##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1049,7 +1049,7 @@ private Type getSnapshotType(IntervalType intvType) {
return null;
}
- private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume) {
+ private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume, boolean isFromVmSnapshot) {
Review comment:
@sureshanaparti made the change. can you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-811325116
<b>Trillian test result (tid-307)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42949 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4739-t307-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 5 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 3643.50 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 70.61 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_01_snapshot_root_disk | `Error` | 0.04 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 11.85 | test_snapshots.py
test_01_snapshot_usage | `Error` | 0.04 | test_usage.py
test_01_migrate_VM_and_root_volume | `Error` | 67.16 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 50.07 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-805748164
> @weizhouapache @ravening any update on this?
not sure what update is needed here @rhtyd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#discussion_r629307599
##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1049,7 +1049,7 @@ private Type getSnapshotType(IntervalType intvType) {
return null;
}
- private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume) {
+ private boolean hostSupportSnapsthotForVolume(HostVO host, VolumeInfo volume, boolean isFromVmSnapshot) {
Review comment:
good suggestion. @ravening could you change it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-788107683
so if you want to create a template from a vm-snapshot you need to first create a volume snapshot from it, tnx @ravening .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-788346365
> I am struggling to see the use-case. Can you explain why you want this, @ravening?
for stopped vms, we can create volume snapshot no matter if kvm.snapshot.enabled is true or false.
for running vms, if kvm.snapshot.enabled is false, we cannot create volume snapshot
if kvm.snapshot.enabled is true, we can create volume snapshot by following steps in cloudstack if image is qcow2 format.
(1) create vm snapshot (vm will be paused)
(2) create volume snapshot from the vm snapshot
If we already have a vm snapshot, even if kvm.snapshot.enabled is false, we should be able to create volume snapshot from vmsnapshot (step 2 above), as vm will not be paused and vm image will not be touched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-923693746
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888932296
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-788080438
> I am struggling to see the use-case. Can you explain why you want this, @ravening?
@DaanHoogland
sometimes we need to create a template or volume from snapshot. If the global setting is false then we cant create snapshot and hence we cant create template also. But with this change, we are able to create those
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-923801081
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-923692760
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888933975
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-788079102
I am struggling to see the use-case. Can you explain why you want this, @ravening?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888892264
@Pearl1594 if possible can you run the test again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-821104852
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-809179181
loads of travis errors @ravening , can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-806124060
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888934678
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-820183622
Re-ping @ravening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-821091658
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-923729739
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-807091868
me neither @rhtyd are you missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-888912369
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-810756464
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-807100313
> code looks good, any marvin or other test automation @ravening ?
@DaanHoogland didnt think of writing any automation test cases.. tested it manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-810788379
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-812989020
@ravening pl check snapshot related failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4739: Allow creating snapshot from VM snapshot
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4739:
URL: https://github.com/apache/cloudstack/pull/4739#issuecomment-810779211
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org