You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/27 13:03:50 UTC
[GitHub] [beam] damccorm opened a new pull request, #17476: [BEAM-11105] Add timestamp observing watermark estimation
damccorm opened a new pull request, #17476:
URL: https://github.com/apache/beam/pull/17476
**Summary of Changes**
This pr is a continuation of building watermark support in the Go Sdk. It builds on the work done in https://github.com/apache/beam/pull/17374 and introduces the ability for watermark estimators to be updated based on the timestamp of emitted elements. It includes the following changes:
- Execution (emit/emit.go, exec/pardo.go, sdf/sdf.go)
- Code generation (generate/generate.go, **.shims.go, optimized/emitters.tmpl, optimized/emitters.go)
- Concrete implementation of a timestamp observing estimator (sdf/watermark_estimator.go)
This is built according to the design specified here - https://docs.google.com/document/d/1DqCYJ-J1YGNelCRIcN5v6BQsZxJB2l5uWBmN4ti--Ew/edit?usp=sharing
**Next Steps**
The following work remains to be implemented after this is completed
- Manual estimators (PR in progress - https://github.com/apache/beam/pull/17475)
- Doc changes
**Manual Testing**
On top of all the unit tests introduced, I hacked the existing textio sdf doFn and added the following function:
```
func (fn *readSdfFn) CreateWatermarkEstimator(t time.Time) *sdf.TimestampObservingWatermarkEstimator {
return &sdf.TimestampObservingWatermarkEstimator{State: t}
}
func (fn *readSdfFn) InitialWatermarkEstimatorState(_ beam.EventTime, _ offsetrange.Restriction, _ string, _ int64) time.Time {
return time.Now().AddDate(-1, 0, 0)
}
func (fn *readSdfFn) WatermarkEstimatorState(e *sdf.TimestampObservingWatermarkEstimator) time.Time {
return e.State
}
```
and emitted elements 10 years in the future from processElement. Then I ran wordCount (with the textio sdf version) on dataflow so that I could observe the output watermark was getting correctly updated to the current wall clock time + 1 month:
<img width="437" alt="image" src="https://user-images.githubusercontent.com/42773683/165524201-8a16ad7f-4ca0-4d46-9b8d-37dcb9d8eb5c.png">
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1110974676
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #17476:
URL: https://github.com/apache/beam/pull/17476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111131155
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1114845888
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1114457635
Will merge once the conflict is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1110974670
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1114845515
> Will merge once the conflict is resolved.
Done - thanks! It looks like GoPortable is failing, but on the :sdks:java:container:pullLicenses. I'll try rerunning it, but I don't think that should block us from merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1110974665
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111021815
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on a diff in pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
lostluck commented on code in PR #17476:
URL: https://github.com/apache/beam/pull/17476#discussion_r862082099
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -96,3 +98,12 @@ type WatermarkEstimator interface {
// splits or checkpoints to advance the output watermark of the restriction's stage.
CurrentWatermark() time.Time
}
+
+// ToWatermarkEstimator is an interface used to represent a user defined watermark estimator that
+// has the ability to observe timestamps of elements outputted from a ParDo's emit function.
+type ToWatermarkEstimator interface {
Review Comment:
If TO is supposed to be an acronym for TimestampObserving, please capitalize it accordingly.
I'd also recommend simplifying it to `TimestampObserver`. Yes it only applies to WatermarkEstimators with the embed, but that can be clarified in the type documentation, rather than the whole name.
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -96,3 +98,12 @@ type WatermarkEstimator interface {
// splits or checkpoints to advance the output watermark of the restriction's stage.
CurrentWatermark() time.Time
}
+
+// ToWatermarkEstimator is an interface used to represent a user defined watermark estimator that
+// has the ability to observe timestamps of elements outputted from a ParDo's emit function.
+type ToWatermarkEstimator interface {
Review Comment:
If TO is supposed to be an acronym for TimestampObserving, please capitalize it accordingly. As it stands, it sounds like a type that converts types to WatermarkEstimators.
I recommend simplifying it to `TimestampObserver`. Yes ,it only applies to WatermarkEstimators with the embed, but that can also be clarified in the type documentation, rather than the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1115238752
> Agreed that it's unrelated. Running one more time, but will still merge after.
Oh nice, that did it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1115227506
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] riteshghorse commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
riteshghorse commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111505650
Didn't look at the generated, .tmpl code but rest looks readable and good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111575477
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111021110
# [Codecov](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17476](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c53a58) into [master](https://codecov.io/gh/apache/beam/commit/385de1b820e42dd2657117a840a4d46b95922c7c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (385de1b) will **decrease** coverage by `0.03%`.
> The diff coverage is `41.73%`.
```diff
@@ Coverage Diff @@
## master #17476 +/- ##
==========================================
- Coverage 73.88% 73.85% -0.04%
==========================================
Files 690 690
Lines 90761 90817 +56
==========================================
+ Hits 67062 67071 +9
- Misses 22490 22531 +41
- Partials 1209 1215 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `49.99% <41.73%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/beam.shims.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9iZWFtLnNoaW1zLmdv) | `38.85% <0.00%> (-1.15%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/runtime/exec/emit.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9lbWl0Lmdv) | `47.36% <0.00%> (-4.56%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/sdf/watermark\_estimator.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3NkZi93YXRlcm1hcmtfZXN0aW1hdG9yLmdv) | `0.00% <0.00%> (ø)` | |
| [sdks/go/pkg/beam/testing/passert/passert.shims.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90ZXN0aW5nL3Bhc3NlcnQvcGFzc2VydC5zaGltcy5nbw==) | `57.23% <0.00%> (-0.94%)` | :arrow_down: |
| [sdks/go/pkg/beam/transforms/filter/filter.shims.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL2ZpbHRlci9maWx0ZXIuc2hpbXMuZ28=) | `46.42% <0.00%> (-2.94%)` | :arrow_down: |
| [sdks/go/pkg/beam/x/debug/debug.shims.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS94L2RlYnVnL2RlYnVnLnNoaW1zLmdv) | `71.02% <0.00%> (-2.76%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/runtime/exec/pardo.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9wYXJkby5nbw==) | `48.54% <30.00%> (-2.13%)` | :arrow_down: |
| [sdks/go/pkg/beam/transforms/stats/stats.shims.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS90cmFuc2Zvcm1zL3N0YXRzL3N0YXRzLnNoaW1zLmdv) | `48.77% <64.91%> (ø)` | |
| [sdks/go/pkg/beam/util/shimx/generate.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS91dGlsL3NoaW14L2dlbmVyYXRlLmdv) | `88.88% <66.66%> (-0.51%)` | :arrow_down: |
| [sdks/go/pkg/beam/core/graph/mtime/time.go](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL2dyYXBoL210aW1lL3RpbWUuZ28=) | `55.00% <100.00%> (+3.64%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/beam/pull/17476/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [385de1b...1c53a58](https://codecov.io/gh/apache/beam/pull/17476?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1111574917
R: @lostluck for final review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1114869303
It failed again, FWIW it is also failing in this pr with none of the same changes - https://github.com/apache/beam/pull/17522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #17476:
URL: https://github.com/apache/beam/pull/17476#issuecomment-1115229649
Agreed that it's unrelated. Running one more time, but will still merge after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #17476: [BEAM-11105] Add timestamp observing watermark estimation
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #17476:
URL: https://github.com/apache/beam/pull/17476#discussion_r862211506
##########
sdks/go/pkg/beam/core/sdf/sdf.go:
##########
@@ -96,3 +98,12 @@ type WatermarkEstimator interface {
// splits or checkpoints to advance the output watermark of the restriction's stage.
CurrentWatermark() time.Time
}
+
+// ToWatermarkEstimator is an interface used to represent a user defined watermark estimator that
+// has the ability to observe timestamps of elements outputted from a ParDo's emit function.
+type ToWatermarkEstimator interface {
Review Comment:
I ended up going with TimestampObservingEstimator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org