You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by cs...@apache.org on 2019/08/05 12:03:18 UTC

[sling-org-apache-sling-distribution-journal] branch master updated: GRANITE-26607 - Fix resource leak

This is an automated email from the ASF dual-hosted git repository.

cschneider pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-distribution-journal.git


The following commit(s) were added to refs/heads/master by this push:
     new a64f1b4  GRANITE-26607 - Fix resource leak
a64f1b4 is described below

commit a64f1b45bfb04bb23aea60c5dc82a297159451ca
Author: Christian Schneider <cs...@adobe.com>
AuthorDate: Mon Aug 5 14:03:08 2019 +0200

    GRANITE-26607 - Fix resource leak
---
 .../journal/impl/subscriber/ContentPackageExtractor.java    | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java b/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java
index 916431e..2f85f9b 100644
--- a/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java
+++ b/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/ContentPackageExtractor.java
@@ -86,12 +86,13 @@ public class ContentPackageExtractor {
             log.info("Content package received at {}. Starting import.\n", path);
             Session session = node.getSession();
             JcrPackageManager packMgr = packageService.getPackageManager(session);
-            JcrPackage pack = packMgr.open(node);
-            ImportOptions opts = new ImportOptions();
-            if (packageHandling == PackageHandling.Extract) {
-                pack.extract(opts);
-            } else {
-                pack.install(opts);
+            try (JcrPackage pack = packMgr.open(node)) {
+                ImportOptions opts = new ImportOptions();
+                if (packageHandling == PackageHandling.Extract) {
+                    pack.extract(opts);
+                } else {
+                    pack.install(opts);
+                }
             }
         } catch (Exception e) {
             log.warn("Error trying to extracting content package on path {}.", path, e);