You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/09/24 13:06:02 UTC

[GitHub] spark pull request #22526: [SPARK-25502][CORE][WEBUI]Empty Page when page nu...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22526#discussion_r219827419
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -685,7 +685,15 @@ private[ui] class TaskDataSource(
     
       private var _tasksToShow: Seq[TaskData] = null
     
    -  override def dataSize: Int = taskCount(stage)
    +  override def dataSize: Int = {
    +    val storedTasks = store.taskCount(stage.stageId, stage.attemptId).toInt
    +    val totalTasks = taskCount(stage)
    +    if (totalTasks > storedTasks) {
    --- End diff --
    
    Oh, hm I would have thought it's simpler to return the single value that this always takes on.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org