You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrew Schwartzmeyer (JIRA)" <ji...@apache.org> on 2017/09/26 17:00:17 UTC

[jira] [Assigned] (MESOS-7946) DefaultExecutorTest.SigkillExecutor test fails on Windows

     [ https://issues.apache.org/jira/browse/MESOS-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Schwartzmeyer reassigned MESOS-7946:
-------------------------------------------

    Resolution: Fixed
      Assignee: Andrei Budnik  (was: Gilbert Song)

{noformat}
commit 4a3d776a3
Author: Andrei Budnik <ab...@mesosphere.com>
Date:   Wed Sep 13 17:58:59 2017 +0200

    Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on Windows.

    Processes terminated by `os::killtree()` exit normally with a status
    code on Windows, but killed by a signal on Linux. Prior to this patch,
    we expected a process to be always killed by a signal, which caused
    test failure on Windows. Since we don't care about the exact value of
    a returned status code in this test, this check was removed.

    Review: https://reviews.apache.org/r/62279/
{noformat}

> DefaultExecutorTest.SigkillExecutor test fails on Windows
> ---------------------------------------------------------
>
>                 Key: MESOS-7946
>                 URL: https://issues.apache.org/jira/browse/MESOS-7946
>             Project: Mesos
>          Issue Type: Bug
>          Components: executor, test
>         Environment: Windows 10
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrei Budnik
>              Labels: windows
>
> {noformat}
> commit 9ca2cc8ae751905f078b056b265fb4511ea8e5f4
> Author: Gilbert Song songzihao1990@gmail.com
> Date:   Tue Aug 29 17:31:35 2017 -0700
> Added unit test for killing the default executor process.
> Review: https://reviews.apache.org/r/61981
> {noformat}
> The above commit introduced the test {{MesosContainerizer/DefaultExecutorTest.SigkillExecutor}} which fails on Windows. At a rough glance, if this is dependent on the {{SIGKILL}} signal, it may not be applicable on Windows and just needs to be disabled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)