You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/02/14 19:56:54 UTC

[GitHub] mitchell852 edited a comment on issue #3312: Disallow underscore in xmlId

mitchell852 edited a comment on issue #3312: Disallow underscore in xmlId
URL: https://github.com/apache/trafficcontrol/issues/3312#issuecomment-463769953
 
 
   https://github.com/apache/trafficcontrol/blob/master/traffic_portal/app/src/common/modules/form/deliveryService/form.deliveryService.DNS.tpl.html#L101
   
   TP only checks that you don't have spaces in the xml id
   
   `ng-pattern="/^\S*$/"`
   
   a. it's great if the API is doing a tighter validation. is it? is it comprehensive?
   b. i think it's fine to duplicate that validation in TP but seems like a lower priority as the api does it anyhow.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services