You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/02 10:17:58 UTC

[jira] [Commented] (CB-12018) Update tests to use jasmine instead of jasmine-node

    [ https://issues.apache.org/jira/browse/CB-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15792621#comment-15792621 ] 

ASF GitHub Bot commented on CB-12018:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-js/pull/140

    fixjasmine: CB-12018 : updated tests to work with jasmine and added t…

    …est labels
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    Updates tests to function with jasmine over jasmine-node.
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-js fixjasmine

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 818156e080b951a462c8347cda848828548f4eb5
Author: audreyso <au...@adobe.com>
Date:   2016-12-29T01:32:35Z

    fixjasmine: CB-12018 : updated tests to work with jasmine and added test labels

----


> Update tests to use jasmine instead of jasmine-node
> ---------------------------------------------------
>
>                 Key: CB-12018
>                 URL: https://issues.apache.org/jira/browse/CB-12018
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, CordovaCommon, CordovaLib, Plugman
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: cordova-7.0.0
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org