[GitHub] [incubator-superset] williaster commented on issue #8976: [SIP-34] Proposal to establish a new design direction, system, and process for Superset

[GitBox <gi...@apache.org>]

williaster commented on issue #8976: [SIP-34] Proposal to establish a new design direction, system, and process for Superset
URL: https://github.com/apache/incubator-superset/issues/8976#issuecomment-575286859
 
 
   > The implementation of this SIP should iterate toward deprecating the React-Bootstrap dependency, in favor of bespoke components with custom LESS styles built around this new design system.
   
   I'm curious if it would make sense to move to a more modern CSS in JS approach for styling components. This supports a shared `theme` object for fonts, colors, sizing, etc., while encapsulating and co-locating specific styles to individual components. This tends to mitigate the risk of bloated css over time which occurs because it's very difficult to isolate and remove `class-name`-based styles. [Lunar](https://github.com/airbnb/lunar) ([demo](https://airbnb.io/lunar/)) is an example of such a library, we could consider it.
   
   > in favor of bespoke components with custom LESS styles
   
   By this phrasing do you mean **not** using any component library (like react bootstrap)? I would note that it is a **significant** amount of work to write a component library from scratch, even if components are replaced individually one at a time. 
   
   > All changes, in the design and implementation of new components, should be "atomic" in nature, steering toward a more unified design/component system, targeting reusability and consistency.
   
   I generally agree with this, but it seems worthwhile to align on a more specific component library or approach for new / implemented components in this SIP. If there is ambiguity, there might be a variety of libraries / frameworks introduced, or if it is unclear what to use Bootstrap 3 might continue to be used.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org