You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2017/10/17 17:29:04 UTC
Review Request 63082: Hide InstanceHistory when there are no old
tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63082/
-----------------------------------------------------------
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Repository: aurora
Description
-------
Hide InstanceHistory when no old tasks.
Diffs
-----
ui/src/main/js/components/InstanceHistory.js fb0639079d227ba19cf97ed1061d6a55db0f0497
ui/src/main/js/components/__tests__/InstanceHistory-test.js 16314810312a48d44faeaa795640db48b225d243
Diff: https://reviews.apache.org/r/63082/diff/1/
Testing
-------
File Attachments
----------------
No old tasks
https://reviews.apache.org/media/uploaded/files/2017/10/17/be3f31f6-d681-48e2-8ca7-708a85ca278b__Screen_Shot_2017-10-17_at_10.28.08_AM.png
Thanks,
David McLaughlin
Re: Review Request 63082: Hide InstanceHistory when there are no old
tasks.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63082/#review188353
-----------------------------------------------------------
Ship it!
Master (b1648aa) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 17, 2017, 5:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63082/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:30 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hide InstanceHistory when no old tasks.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/InstanceHistory.js fb0639079d227ba19cf97ed1061d6a55db0f0497
> ui/src/main/js/components/__tests__/InstanceHistory-test.js 16314810312a48d44faeaa795640db48b225d243
>
>
> Diff: https://reviews.apache.org/r/63082/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> No old tasks
> https://reviews.apache.org/media/uploaded/files/2017/10/17/be3f31f6-d681-48e2-8ca7-708a85ca278b__Screen_Shot_2017-10-17_at_10.28.08_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63082: Hide InstanceHistory when there are no old
tasks.
Posted by Kai Huang <te...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63082/#review188348
-----------------------------------------------------------
Ship it!
Ship It!
- Kai Huang
On Oct. 17, 2017, 5:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63082/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 5:30 p.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hide InstanceHistory when no old tasks.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/InstanceHistory.js fb0639079d227ba19cf97ed1061d6a55db0f0497
> ui/src/main/js/components/__tests__/InstanceHistory-test.js 16314810312a48d44faeaa795640db48b225d243
>
>
> Diff: https://reviews.apache.org/r/63082/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> No old tasks
> https://reviews.apache.org/media/uploaded/files/2017/10/17/be3f31f6-d681-48e2-8ca7-708a85ca278b__Screen_Shot_2017-10-17_at_10.28.08_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63082: Hide InstanceHistory when there are no old
tasks.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63082/#review188375
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On Oct. 17, 2017, 10:30 a.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63082/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:30 a.m.)
>
>
> Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Hide InstanceHistory when no old tasks.
>
>
> Diffs
> -----
>
> ui/src/main/js/components/InstanceHistory.js fb0639079d227ba19cf97ed1061d6a55db0f0497
> ui/src/main/js/components/__tests__/InstanceHistory-test.js 16314810312a48d44faeaa795640db48b225d243
>
>
> Diff: https://reviews.apache.org/r/63082/diff/2/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> No old tasks
> https://reviews.apache.org/media/uploaded/files/2017/10/17/be3f31f6-d681-48e2-8ca7-708a85ca278b__Screen_Shot_2017-10-17_at_10.28.08_AM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 63082: Hide InstanceHistory when there are no old
tasks.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63082/
-----------------------------------------------------------
(Updated Oct. 17, 2017, 5:30 p.m.)
Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham.
Changes
-------
Delete stale code.
Repository: aurora
Description
-------
Hide InstanceHistory when no old tasks.
Diffs (updated)
-----
ui/src/main/js/components/InstanceHistory.js fb0639079d227ba19cf97ed1061d6a55db0f0497
ui/src/main/js/components/__tests__/InstanceHistory-test.js 16314810312a48d44faeaa795640db48b225d243
Diff: https://reviews.apache.org/r/63082/diff/2/
Changes: https://reviews.apache.org/r/63082/diff/1-2/
Testing
-------
File Attachments
----------------
No old tasks
https://reviews.apache.org/media/uploaded/files/2017/10/17/be3f31f6-d681-48e2-8ca7-708a85ca278b__Screen_Shot_2017-10-17_at_10.28.08_AM.png
Thanks,
David McLaughlin