[jira] [Commented] (HIVE-9744) Move common arguments validation and value extraction code to GenericUDF

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-9744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336171#comment-14336171 ] 

Hive QA commented on HIVE-9744:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12700666/HIVE-9744.1.patch

{color:green}SUCCESS:{color} +1 7567 tests passed

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2866/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2866/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2866/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12700666 - PreCommit-HIVE-TRUNK-Build

> Move common arguments validation and value extraction code to GenericUDF
> ------------------------------------------------------------------------
>
>                 Key: HIVE-9744
>                 URL: https://issues.apache.org/jira/browse/HIVE-9744
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-9744.1.patch
>
>
> most of the UDFs 
> - check if arguments are primitive / complex
> - check if arguments are particular type or type_group
> - get converters to read values
> - check if argument is constant
> - extract arguments values
> Probably we should move these common methods to GenericUDF



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)