You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/24 12:40:04 UTC

[GitHub] [flink] wuchong commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

wuchong commented on pull request #14376:
URL: https://github.com/apache/flink/pull/14376#issuecomment-805787270


   Regarding to the topics @libenchao  raised,
   
   1.  I perfer not failing the job. Filling with default values sounds good to me. But the default value should be configurable. 
   2. Generating code using Java is tricky now. There are some existing code as a references, e.g. `org.apache.flink.table.data.conversion.StructuredObjectConverter#generateCode`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org