[GitHub] [beam] KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests

[GitBox <gi...@apache.org>]

KevinGG commented on a change in pull request #11338: [BEAM-7923] Screendiff Integration Tests
URL: https://github.com/apache/beam/pull/11338#discussion_r405731238
 
 

 ##########
 File path: sdks/python/apache_beam/runners/interactive/testing/integration/screen_diff.py
 ##########
 @@ -0,0 +1,203 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Module to conduct screen diff based notebook integration tests."""
+
+# pytype: skip-file
+
+from __future__ import absolute_import
+
+import os
+import threading
+import unittest
+from http.server import SimpleHTTPRequestHandler
+from http.server import ThreadingHTTPServer
+from multiprocessing import Process
+
+from apache_beam.runners.interactive import interactive_environment as ie
+from apache_beam.runners.interactive.testing.integration import notebook_executor
+
+try:
+  import chromedriver_binary  # pylint: disable=unused-import
+  from needle.cases import NeedleTestCase
 
 Review comment:
   It is a normal unit test.
   This will be picked up and skipped (since I don't intend to put it in Beam pre-commit yet) with existing test suites.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services