You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/08 18:11:48 UTC
[GitHub] [flink] azagrebin opened a new pull request #11675: [Flink 16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
azagrebin opened a new pull request #11675: [Flink 16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675
## What is the purpose of the change
`JobManagerProcessUtils#processSpecFromConfig` is used to get `JobManagerProcessSpec` in `AbstractContainerizedClusterClientFactory#getClusterSpecification`. Then `JobManagerProcessSpec` is passed to `ProcessMemoryUtils#generateJvmParametersStr` to get JVM memory arg list string in `YarnClusterDescriptor#setupApplicationMasterContainer` and `JavaCmdJobManagerDecorator#getJobManagerStartCommand`. The configuration is also fixed to fallback to `JobManagerOptions.TOTAL_PROCESS_MEMORY` if a legacy option is set (`JobManagerProcessUtils#getConfigurationWithLegacyHeapSizeMappedToNewConfigOption`) before passing it to `JobManagerProcessUtils#processSpecFromConfig`.
Then the JVM memory args are used to start JM container and its JVM process for Yarn and Kubernetes active integrations instead of using the existing legacy heap options: `jobmanager.heap.size` (or `jobmanager.heap.mb`) and container cut-off options: `containerized.heap-cutoff-ratio` and `containerized.heap-cutoff-min`. The container cut-off options are then removed as they have no effect anymore.
## Verifying this change
Existing unit tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159425157) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6c25127857182988536a5436329efc1e61f4540 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160244430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477)
* 928f421f94905d2f62b436b22ea549bd60972cf6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160362183) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 928f421f94905d2f62b436b22ea549bd60972cf6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509)
* c2dbf01fb067175eeee9d26c3696e20f75da9936 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6c25127857182988536a5436329efc1e61f4540 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160244430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477)
* 928f421f94905d2f62b436b22ea549bd60972cf6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159425157) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237)
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159561958) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407356875
##########
File path: docs/ops/memory/mem_migration.zh.md
##########
@@ -121,9 +121,7 @@ Flink 自带的[默认 flink-conf.yaml](#flink-confyaml-中的默认配置) 文
网络内存的大小可能会受到其他内存部分大小变化的影响,例如总内存变化时,根据占比计算出的网络内存也可能发生变化。
请参考[内存模型详解](mem_detail.html)。
-容器切除(Cut-Off)内存相关的配置参数([`containerized.heap-cutoff-ratio`](config.html#containerized-heap-cutoff-ratio)
-和 [`containerized.heap-cutoff-min`](config.html#containerized-heap-cutoff-min))将不再对 TaskExecutor 进程生效。
-对于 JobManager 进程,它们仍具有与此前相同的语义。
+容器切除(Cut-Off)内存相关的配置参数(`containerized.heap-cutoff-ratio` 和 `containerized.heap-cutoff-min`)将不再对进程生效。
请参考[如何升级容器切除内存](#容器切除cut-off内存)。
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r409260812
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
##########
@@ -18,20 +18,35 @@
package org.apache.flink.client.deployment;
+import org.apache.flink.runtime.jobmanager.JobManagerProcessSpec;
+import org.apache.flink.util.Preconditions;
+
+import static org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.createDefaultJobManagerProcessSpec;
+
/**
* Description of the cluster to start by the {@link ClusterDescriptor}.
*/
public final class ClusterSpecification {
+ private final JobManagerProcessSpec masterProcessSpec;
Review comment:
True, it makes sense to derive `JobManagerProcessSpec` in one place for all integrations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6c25127857182988536a5436329efc1e61f4540 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160244430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 928f421f94905d2f62b436b22ea549bd60972cf6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362183) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159561958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275)
* f6c25127857182988536a5436329efc1e61f4540 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2dbf01fb067175eeee9d26c3696e20f75da9936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160388143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528)
* 5e8b9ed9f8cebd2376bba6b8455b2d08d027913d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on issue #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611418568
cc @xintongsong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 928f421f94905d2f62b436b22ea549bd60972cf6 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362183) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509)
* c2dbf01fb067175eeee9d26c3696e20f75da9936 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160388143) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159561958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275)
* f6c25127857182988536a5436329efc1e61f4540 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160244430) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
azagrebin commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r408748657
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
##########
@@ -18,20 +18,35 @@
package org.apache.flink.client.deployment;
+import org.apache.flink.runtime.jobmanager.JobManagerProcessSpec;
+import org.apache.flink.util.Preconditions;
+
+import static org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.createDefaultJobManagerProcessSpec;
+
/**
* Description of the cluster to start by the {@link ClusterDescriptor}.
*/
public final class ClusterSpecification {
+ private final JobManagerProcessSpec masterProcessSpec;
Review comment:
ok, I change it know to not extend `ClusterSpecification`. We can continue discussion in FLINK-16734. In general, I think it would be good to derive `JobManagerProcessSpec` in one place for all integrations and have plan for this if it is not in `ClusterSpecification`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159425157) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237)
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
azagrebin commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r408748657
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
##########
@@ -18,20 +18,35 @@
package org.apache.flink.client.deployment;
+import org.apache.flink.runtime.jobmanager.JobManagerProcessSpec;
+import org.apache.flink.util.Preconditions;
+
+import static org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.createDefaultJobManagerProcessSpec;
+
/**
* Description of the cluster to start by the {@link ClusterDescriptor}.
*/
public final class ClusterSpecification {
+ private final JobManagerProcessSpec masterProcessSpec;
Review comment:
ok, I changed it now to not extend `ClusterSpecification`. We can continue discussion in FLINK-16734. In general, I think it would be good to derive `JobManagerProcessSpec` in one place for all integrations and have plan for this if it is not in `ClusterSpecification`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on issue #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-613963894
Thanks @xintongsong for the reviews. I addressed the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2dbf01fb067175eeee9d26c3696e20f75da9936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160388143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160514750",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2dbf01fb067175eeee9d26c3696e20f75da9936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160388143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528)
* 5e8b9ed9f8cebd2376bba6b8455b2d08d027913d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160514750) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160514750",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e8b9ed9f8cebd2376bba6b8455b2d08d027913d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160514750) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159561958) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160514750",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
}, {
"hash" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579",
"triggerID" : "5e8b9ed9f8cebd2376bba6b8455b2d08d027913d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e8b9ed9f8cebd2376bba6b8455b2d08d027913d Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160514750) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7579)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7477",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "f6c25127857182988536a5436329efc1e61f4540",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160244430",
"triggerID" : "f6c25127857182988536a5436329efc1e61f4540",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362183",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7509",
"triggerID" : "928f421f94905d2f62b436b22ea549bd60972cf6",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
}, {
"hash" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160388143",
"triggerID" : "c2dbf01fb067175eeee9d26c3696e20f75da9936",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2dbf01fb067175eeee9d26c3696e20f75da9936 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/160388143) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7528)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407351155
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1570,7 +1573,7 @@ ContainerLaunchContext setupApplicationMasterContainer(
boolean hasLogback,
boolean hasLog4j,
boolean hasKrb5,
- int jobManagerMemoryMb) {
+ ProcessMemorySpec processSpec) {
Review comment:
Why not `JobManagerProcessSpec`? Do we have any use case that possibly pass in a different `ProcessMemorySpec` implementation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407348935
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/AbstractContainerizedClusterClientFactory.java
##########
@@ -36,9 +38,10 @@
public ClusterSpecification getClusterSpecification(Configuration configuration) {
checkNotNull(configuration);
- final int jobManagerMemoryMB = ConfigurationUtils
- .getJobManagerHeapMemory(configuration)
- .getMebiBytes();
+ final JobManagerProcessSpec jobManagerProcessSpec = JobManagerProcessUtils.processSpecFromConfig(
+ JobManagerProcessUtils.getConfigurationWithLegacyHeapSizeMappedToNewConfigOption(
Review comment:
Unrelated:
I was tracking where this method `getConfigurationWithLegacyHeapSizeMappedToNewConfigOption` lead to, and find that `MemoryBackwardsCompatibilityUtils#getLegacyTaskManagerHeapMemoryIfExplicitlyConfigured` is named "TaskManager" but actually used for both JM & TM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159561958",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
}, {
"hash" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275",
"triggerID" : "fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fd5543dfcfbd5bfb18f3325d2d60473f5a7f10fe Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159561958) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7275)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11675: [FLINK-16745] Use
JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611112172
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 (Wed Apr 08 18:15:18 UTC 2020)
**Warnings:**
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159425157) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11675: [FLINK-16745]
Use JobManagerProcessUtils to start JM container and pass JVM memory args
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#issuecomment-611118888
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
}, {
"hash" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159425157",
"triggerID" : "7bbe43688038441aa0592ee4ef2c8f81e8aef4c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7bbe43688038441aa0592ee4ef2c8f81e8aef4c8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159425157) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7237)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xintongsong commented on a change in pull request #11675:
[FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM
memory args
Posted by GitBox <gi...@apache.org>.
xintongsong commented on a change in pull request #11675: [FLINK-16745] Use JobManagerProcessUtils to start JM container and pass JVM memory args
URL: https://github.com/apache/flink/pull/11675#discussion_r407346335
##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterSpecification.java
##########
@@ -18,20 +18,35 @@
package org.apache.flink.client.deployment;
+import org.apache.flink.runtime.jobmanager.JobManagerProcessSpec;
+import org.apache.flink.util.Preconditions;
+
+import static org.apache.flink.runtime.jobmanager.JobManagerProcessUtils.createDefaultJobManagerProcessSpec;
+
/**
* Description of the cluster to start by the {@link ClusterDescriptor}.
*/
public final class ClusterSpecification {
+ private final JobManagerProcessSpec masterProcessSpec;
Review comment:
I'm not sure about adding `JobManagerProcessSpec` into `ClusterSpecification`.
Actually, I was thinking about removing `ClusterSpecification`. After FLIP-116, all the information that `ClusterSpecification` carries can derived from configuration. We don't really need this data structure to hold the information, with the risk of potential inconsistency due to using `MB`. Please see FLINK-16734 for more details.
Removing `ClusterSpecification` involves refactoring `ClusterDescriptor`, which is not necessary for this PR. But I would suggest to not add more usages to it.
I think we can do the same thing for `masterMemoryMB` as we did for `taskManagerMemoryMB`:
- Make `JavaCmdJobManagerDecorator#decorateFlinkPod` and `YarnClusterDescriptor#startAppMaster` derive `JobManagerProcessSpec` from configuration.
- Leave it for `YarnClusterDescriptor#validateClusterResources`, but do not try to overwrite `jobManagerMemoryMb` when it is smaller than `yarnMinAllocationMB`.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services