You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/08/12 09:18:44 UTC

[GitHub] [sling-org-apache-sling-bundleresource-impl] kwin commented on a diff in pull request #1: SLING-11504 BundleResource/JcrNodeResource getResourceType fallback consistency

kwin commented on code in PR #1:
URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/1#discussion_r944275677


##########
src/main/java/org/apache/sling/bundleresource/impl/PathMapping.java:
##########
@@ -44,18 +46,20 @@ public static PathMapping[] getRoots(final String rootList) {
             final String resourceRoot = entry.getValue();
             final String pathDirective = entry.getDirectiveValue(DIR_PATH);
             final String expandDirective = entry.getDirectiveValue(DIR_JSON);
+            final boolean skipSettingResourceTypeProperty = Boolean.parseBoolean(entry.getDirectiveValue(SKIP_SETTING_RESOURCE_TYPE_FLAG));

Review Comment:
   Maybe "hideResourceTypeProperties" is the better name (and an according constant name value).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org