You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 03:09:03 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new issue, #23184: Add e2e test for SQL HINT.

tuichenchuxin opened a new issue, #23184:
URL: https://github.com/apache/shardingsphere/issues/23184

   # BackGround
   Through this #20736, we support SQL HINT. 
   There are currently two ways, one is to enable the comment parsing switch `sqlCommentParseEnabled: true`, then the information of SQL HINT will be extracted through antlr parser. 
   The other is to turn off the comment parsing switch `sqlCommentParseEnabled: false`, which allows the same SQL but different comment information to use the same cache, thereby improving performance.
   # Task
   
   - [ ] Add e2e test for SQL HINT with `sqlCommentParseEnabled: true`
   - [ ] Add e2e test for SQL HINT with `sqlCommentParseEnabled: false`
   
   I have added one test for example.
   https://github.com/apache/shardingsphere/pull/22727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] dongzl commented on issue #23184: Add e2e test for SQL HINT.

Posted by GitBox <gi...@apache.org>.
dongzl commented on issue #23184:
URL: https://github.com/apache/shardingsphere/issues/23184#issuecomment-1367700944

   Hi @tuichenchuxin , I will try it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuichenchuxin commented on issue #23184: Add e2e test for SQL HINT.

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin commented on issue #23184:
URL: https://github.com/apache/shardingsphere/issues/23184#issuecomment-1447497746

   @dongzl hi, how has this issue progressed lately? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org