You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/17 05:47:42 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #4214: Bug fixes for primate
davidjumani opened a new pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214
## Description
Adding the following fixes so primate can work without issues :
- Adding pagination for listNetworkAclLists
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-659962192
@davidjumani can you rebase against 4.14 branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660028878
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660016729
Packaging result: ✔centos7 ✔debian. JID-1588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663509615
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-664139720
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663509061
Packaging result: ✔centos7 ✔debian. JID-1601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660445470
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660001681
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660524432
<b>Trillian test result (tid-2140)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37492 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4214-t2140-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-664139483
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#discussion_r456311597
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1064,9 +1062,8 @@
sc.setParameters("keyPairName", keyPairName);
}
- if (cmd instanceof ListVMsCmdByAdmin) {
- ListVMsCmdByAdmin aCmd = (ListVMsCmdByAdmin)cmd;
- if (aCmd.getPodId() != null) {
+ if (_accountMgr.isRootAdmin(caller.getId())) {
Review comment:
@rhtyd Is there a better way to do this? If not, can entirely remove ListVmsCmdByAdmin since it's no longer used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660001992
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663499159
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660444563
Packaging result: ✔centos7 ✔debian. JID-1589
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-659979903
@rhtyd done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663499454
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-664213195
Additional review/testing requested from @Pearl1594 @ravening @utchoang @shwstppr - thanx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#discussion_r460743734
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -1064,9 +1062,8 @@
sc.setParameters("keyPairName", keyPairName);
}
- if (cmd instanceof ListVMsCmdByAdmin) {
- ListVMsCmdByAdmin aCmd = (ListVMsCmdByAdmin)cmd;
- if (aCmd.getPodId() != null) {
+ if (_accountMgr.isRootAdmin(caller.getId())) {
Review comment:
this LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660441422
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-664627461
<b>Trillian test result (tid-2196)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50718 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4214-t2196-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_delete_kubernetes_supported_version | `Error` | 1807.38 | test_kubernetes_supported_versions.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663509373
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660441513
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660445612
@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660028457
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: [WIP] Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-663816300
<b>Trillian test result (tid-2191)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 62986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4214-t2191-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 3620.61 | test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster | `Error` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 35.20 | test_kubernetes_clusters.py
ContextSuite context=Test01DeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test02VMLifeCycle>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=Test03SecuredVmMigration>:setup | `Error` | 0.00 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4214: Bug fixes for primate
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4214:
URL: https://github.com/apache/cloudstack/pull/4214#issuecomment-660332974
<b>Trillian test result (tid-2138)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35382 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4214-t2138-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org