You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2023/09/15 19:15:30 UTC
[superset] branch fix-excel-export created (now c59649ac5b)
This is an automated email from the ASF dual-hosted git repository.
beto pushed a change to branch fix-excel-export
in repository https://gitbox.apache.org/repos/asf/superset.git
at c59649ac5b fix: datetime with timezone excel export
This branch includes the following new commits:
new c59649ac5b fix: datetime with timezone excel export
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: fix: datetime with timezone excel export
Posted by be...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
beto pushed a commit to branch fix-excel-export
in repository https://gitbox.apache.org/repos/asf/superset.git
commit c59649ac5b7d4e78038221d32a91c0ba36db3887
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Fri Sep 15 12:13:13 2023 -0700
fix: datetime with timezone excel export
---
superset/utils/excel.py | 5 +++++
.../excel.py => tests/unit_tests/utils/excel_tests.py | 18 ++++++++++--------
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/superset/utils/excel.py b/superset/utils/excel.py
index 1f68031b64..2119d20926 100644
--- a/superset/utils/excel.py
+++ b/superset/utils/excel.py
@@ -22,6 +22,11 @@ import pandas as pd
def df_to_excel(df: pd.DataFrame, **kwargs: Any) -> Any:
output = io.BytesIO()
+
+ # timezone are not supported
+ for column in df.select_dtypes(include=["datetimetz"]).columns:
+ df[column] = df[column].astype(str)
+
# pylint: disable=abstract-class-instantiated
with pd.ExcelWriter(output, engine="xlsxwriter") as writer:
df.to_excel(writer, **kwargs)
diff --git a/superset/utils/excel.py b/tests/unit_tests/utils/excel_tests.py
similarity index 67%
copy from superset/utils/excel.py
copy to tests/unit_tests/utils/excel_tests.py
index 1f68031b64..c15f69a0c6 100644
--- a/superset/utils/excel.py
+++ b/tests/unit_tests/utils/excel_tests.py
@@ -14,16 +14,18 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-import io
-from typing import Any
+
+from datetime import datetime, timezone
import pandas as pd
+from superset.utils.excel import df_to_excel
-def df_to_excel(df: pd.DataFrame, **kwargs: Any) -> Any:
- output = io.BytesIO()
- # pylint: disable=abstract-class-instantiated
- with pd.ExcelWriter(output, engine="xlsxwriter") as writer:
- df.to_excel(writer, **kwargs)
- return output.getvalue()
+def test_timezone_conversion() -> None:
+ """
+ Test that columns with timezones are converted to a string.
+ """
+ df = pd.DataFrame({"dt": [datetime(2023, 1, 1, 0, 0, tzinfo=timezone.utc)]})
+ contents = df_to_excel(df)
+ assert pd.read_excel(contents)["dt"][0] == "2023-01-01 00:00:00+00:00"