You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 19:37:56 UTC
[GitHub] [incubator-nuttx] kernelgurumeditation opened a new pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
kernelgurumeditation opened a new pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353
## Summary
Small fix to enable OTG FS HOST capability of the nucleo-h743zi board
Added also a default configuration file with this capability enabled
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731770326
@davids5 I agree but in this case this is more of an exception. The changes in terms of user impact is very minor and the USB seems to be the biggest issue where it's really just the power line. You would not even notice the difference ordering unless you really look hard.
I don't want to duplicate everything just because ST did a board rev and all the code is the same except for two lines.
Also all other STM32H7 use this MB and is called out as _the_ MB for the H7 family. I suspect the use of the original MB was a mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731631249
@kernelgurumeditation I have a few changes to fixup some of the logic around enabling USB features as well as the warnings.
I do not quite have this working yet, but I expect I will have it working today. There is a warning about the USB stack not being tested on the STM32H7 yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731640692
Ah amazing.... this is answered here: https://www.st.com/resource/en/data_brief/nucleo-h743zi.pdf
They have replaced the MB1137 with the MB1364. The changes are very minor, but the USB power pin did change and it also has the much improved ST-LINK V3. I might add a board config to support this small difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731770326
@davids5 I agree but in this case this is more of an exception. The changes in terms of user impact is very minor and the USB seems to be the biggest issue where it's really just the power line. You would not even notice the difference ordering unless you really look hard.
I don't want to duplicate everything just because ST did a board rev and all the code is the same except for two lines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] kernelgurumeditation commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
kernelgurumeditation commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731380388
yes... the style check script is really picky! :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731706912
> About the USB bus enable chip... yes :D amazing that they changed the chip and made such a little note about that...
So if you have the "old" version of this board you will want to make sure to set `STM_NUCLEO144_MB1137` when you do testing. I have defaulted to the current version that is shipping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] kernelgurumeditation edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
kernelgurumeditation edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731704865
@btashton , No problem, please go ahead! and thanks for improving it!
About the USB bus enable chip... yes :D amazing that they changed the chip and made such a little note about that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731836396
@davids5 Since ST did not do the work, I made this crude comparison chart for the pin mapping on the breakout
There are a few differences which is frustrating since all the STM32H7 boards in production now and that have been made with the exception of the first rev of the h742zi all use this new layout. Ideally we move to just referring to the pin mappings in the board by there common ZIO name that way we can keep compatibility across all the Nucleo boards. I'll work on trying to clean this up some more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731667222
@kernelgurumeditation would you mind if I pull in my changes and merge this? I have verified that this works. There is another bug I found with the stm32h7 heap allocation that I found that also needs to be fixed, but I will open that in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-732139182
@btashton - Nice Graphic. Thank you, that is the best way for me to see the deltas. I have a really old H7 board. It is MB1137 B-01 if we need to test anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731733825
@btashton To avoid any ambiguity, when adding boards/chips I strive to exact match words (exact spelling) in the data sheet or user manual. I do this so that the NuttX contribution can be linked back to the the mfg's Docs. Since NUCLEO-H743ZI has become NUCLEO-H743ZI**2** and both will exist, should be just create the new board as nucleo-h743zi**2**?
I did not compare the schematics, but what else is different? If this MB change will effect all NUCLEO's and there will be different mother board, we could make it a Kconfig option as well. But we will need to point to the docs on how to tell "What board I have" in that option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731706912
> About the USB bus enable chip... yes :D amazing that they changed the chip and made such a little note about that...
So if you have the "old" version of this board you will want to make sure to set `STM_NUCLEO144_MB1137` when you do testing. I have defaulted to the current version that is shipping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731836396
@davids5 Since ST did not do the work, I made this crude comparison chart for the pin mapping on the breakout
There are a few differences which is frustrating since all the STM32H7 boards in production now and that have been made with the exception of the first rev (called out as `NUCLEO 144 H7 LEGACY`) of the h742zi all use this new layout. Ideally we move to just referring to the pin mappings in the board by there common ZIO name that way we can keep compatibility across all the Nucleo boards. I'll work on trying to clean this up some more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731377305
Also a tip for local testing the style issues.
```
git diff origin/master | ./tools/checkpatch.sh -
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] kernelgurumeditation commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
kernelgurumeditation commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731632262
@btashton
>I have a few changes to fixup some of the logic around enabling USB features as well as the warnings.
I said it was working, but it was not pretty ;)
> There is a warning about the USB stack not being tested on the STM32H7 yet.
Yes, I know, I didn't remove it, because I have done just minimal tests( a couple of GB read/write to a flash drive), and probably it needs better testing before saying it's 100%..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731639111
No worries. There is something wrong here though, you changed the USB bus power control to be active high, but it looks like it is active low and also not on the correct pin. It is not clear to me if there are actually two revisions of the board. They make reference to the STM32 Nucleo 144 (MB1137) and to the STM32H7 Nucleo 144 (MB1364). Can you look on you board and see which number you have near the ST logo?
You can see my changes against your branch here: https://github.com/kernelgurumeditation/incubator-nuttx/compare/OTG_FS_HOST...btashton:OTG_FS_HOST
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731836396
@davids5 Since ST did not do the work, I made this crude comparison chart for the pin mapping on the breakout
There are a few differences which is frustrating since all the STMH7 boards in production now and that have been made with the exception of the first rev of the h742zi all use this new layout. Ideally we move to just referring to the pin mappings in the board by there common ZIO name that way we can keep compatibility across all the Nucleo boards. I'll work on trying to clean this up some more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731370834
Thanks!
One thing off the bat can you use `make savedefconfig` to generate the defconfig file. It will be generated in the base NuttX directory. That will give us the minimal configuration.
I'll give it a functional test this evening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731640692
Ah amazing.... this is answered here: https://www.st.com/resource/en/data_brief/nucleo-h743zi.pdf
They have replaced the MB1137 with the MB1364. The changes are very minor, but the USB power pin did change and it also has the much improved ST-LINK V3. I might add a board Kconfig option to support this small difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731770326
@davids5 I agree but in this case this is more of an exception. The changes in terms of user impact is very minor and the USB seems to be the biggest issue where it's really just the power line. You would not even notice the difference ordering unless you really look hard.
I don't want to duplicate everything just because ST did a board rev and all the code is the same except for two lines.
Also all other STM32H7 use this MB and is called out as _the_ MB for the G7 family. I suspect the use of the original MB was a mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] kernelgurumeditation edited a comment on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
kernelgurumeditation edited a comment on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731632262
@btashton
>I have a few changes to fixup some of the logic around enabling USB features as well as the warnings.
I said it was working, but it was not pretty ;)
> There is a warning about the USB stack not being tested on the STM32H7 yet.
Yes, I know, I didn't remove it, because I have done just minimal tests( a couple of GB read/write to a flash drive), and probably it needs better testing before saying it's 100%..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] kernelgurumeditation commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi
Posted by GitBox <gi...@apache.org>.
kernelgurumeditation commented on pull request #2353:
URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731704865
@btashton , go ahead! and thanks for improving it!
About the USB bus enable chip... yes :D amazing that they changed the chip and made such a little note about that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org