You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/10 12:35:52 UTC
[GitHub] [calcite] vlsi opened a new pull request #1744: Move
logging-related tests to src/loggingTest
vlsi opened a new pull request #1744: Move logging-related tests to src/loggingTest
URL: https://github.com/apache/calcite/pull/1744
@danny0405 , here's a draft of a new testing folder.
It might be better to use `slf4j-test` or something like that for gathering log messages.
The key feature here is the new `loggingTest` folder inherits regular test dependencies + it can declare its own ones.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi closed pull request #1744: Move logging-related
tests to src/loggingTest
Posted by GitBox <gi...@apache.org>.
vlsi closed pull request #1744: Move logging-related tests to src/loggingTest
URL: https://github.com/apache/calcite/pull/1744
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi commented on issue #1744: Move logging-related tests
to src/loggingTest
Posted by GitBox <gi...@apache.org>.
vlsi commented on issue #1744: Move logging-related tests to src/loggingTest
URL: https://github.com/apache/calcite/pull/1744#issuecomment-573314788
> Moves all the tests that needs loggings to another dir seems not that necessary
Technically speaking, I find nothing wrong with implementing targeted tests in the `loggingTest` subfolder.
I moved the full class for simplification purposes.
However, it might make sense to extract a method that needs logging validation and put it to the respective location.
It is more-or-less the same as we select package names for the classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on issue #1744: Move logging-related
tests to src/loggingTest
Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #1744: Move logging-related tests to src/loggingTest
URL: https://github.com/apache/calcite/pull/1744#issuecomment-573270085
Well, what i mostly want is a tool to test the logging behavior, i.e. a tool base method, or an annotation, because i have only one case in my test that needs to track the loggings. Moves all the tests that needs loggings to another dir seems not that necessary.
I mean, i should/could test the logging anywhere if i want, not that i must move my whole test to a specific dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services