You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "Twiggs, Glenn" <Gl...@bmc.com> on 1999/11/25 19:10:32 UTC
RE: cvs commit: jakarta-tools/ant/src/main/org/apache/tools/ant/t
askdefs Javac.java
The compileClasspath variable has already been "localized" before reaching
this point. That is, on WIN32 systems, all the ":" are ";" and the "/" are
"\". This is why the error occurrs. The fix works if your XML is coded as
classpath="dirA:dirB" and you run on WIN32 systems. See the
Javac.setClasspath() method for confirmation.
Glenn.
-----Original Message-----
From: James Duncan Davidson [mailto:james.davidson@eng.sun.com]
Sent: Wednesday, November 24, 1999 5:48 PM
To: tomcat-dev@jakarta.apache.org
Subject: Re: cvs commit:
jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs Javac.java
jons@hyperreal.org wrote:
>
> jons 99/11/24 10:46:02
>
> Modified: ant/src/main/org/apache/tools/ant/taskdefs Javac.java
> Log:
> fix thanks to glenn_twiggs@bmc.com
>
> Revision Changes Path
> 1.12 +2 -1
jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs/Javac.java
>
> Index: Javac.java
> ===================================================================
> RCS file:
/home/cvs/jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs/Javac.jav
a,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -u -r1.11 -r1.12
> --- Javac.java 1999/11/23 21:54:47 1.11
> +++ Javac.java 1999/11/24 18:45:59 1.12
> @@ -306,7 +306,8 @@
> // add our classpath to the mix
>
> if (compileClasspath != null) {
> - StringTokenizer tok = new StringTokenizer(compileClasspath,
":",
> + StringTokenizer tok = new StringTokenizer(compileClasspath,
> + File.pathSeparator,
Actually, dont do this... I haven't yet written up how the format of the
build.xml files should be, but we need a "standard" path and file
seperator in use there that gets translated to native system path
seperator. That's the whole point of parsing here on the ":". If you run
this now on another system, you wont' get valid parsing behavior.
Please back this out.
.duncan
--
James Davidson duncan@eng.sun.com
Java + XML / Portable Code + Portable Data !try; do()
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org
Re: cvs commit:
jakarta-tools/ant/src/main/org/apache/tools/ant/taskdefs Javac.java
Posted by James Duncan Davidson <ja...@eng.sun.com>.
jon * wrote:
>
> on 11/25/99 10:10 AM, Twiggs, Glenn <Gl...@bmc.com> wrote:
>
> > The compileClasspath variable has already been "localized" before reaching
> > this point. That is, on WIN32 systems, all the ":" are ";" and the "/" are
> > "\". This is why the error occurrs. The fix works if your XML is coded as
> > classpath="dirA:dirB" and you run on WIN32 systems. See the
> > Javac.setClasspath() method for confirmation.
> >
> > Glenn.
>
> Ok. I'm confused. Also note that Project.translatePath() is something that I
> wrote, so I'm not sure if it does the right thing as well.
So am I. Glenn, what error are you talking about? I had a small problem
with my mail (actually one of my home systems has gone totally nuts and
is sending out email dated from 1969-2099 and wrote garbage into my imap
server..) and some of it vanished from the face of the earth so I might
have missed the original problem here.
As far as I can tell from Windows and Solaris, everything is working as
expected... Now, it might be interesting to increase the parse tokens to
include ':' and ';' and '/' and '\' so that no matter how the build.xml
file was written, it'll work. But at first glance I'm opposed to that.
.duncan
--
James Davidson duncan@eng.sun.com
Java + XML / Portable Code + Portable Data !try; do()
Re: cvs commit: jakarta-tools/ant/src/main/org/apache/tools/ant/t
askdefs Javac.java
Posted by jon * <jo...@clearink.com>.
on 11/25/99 10:10 AM, Twiggs, Glenn <Gl...@bmc.com> wrote:
> The compileClasspath variable has already been "localized" before reaching
> this point. That is, on WIN32 systems, all the ":" are ";" and the "/" are
> "\". This is why the error occurrs. The fix works if your XML is coded as
> classpath="dirA:dirB" and you run on WIN32 systems. See the
> Javac.setClasspath() method for confirmation.
>
> Glenn.
Ok. I'm confused. Also note that Project.translatePath() is something that I
wrote, so I'm not sure if it does the right thing as well.
James?????
-jon