You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/26 15:35:23 UTC

[GitHub] [incubator-nuttx] fjpanag opened a new pull request #2934: Fixed __stack_overflow_trap declaration typo.

fjpanag opened a new pull request #2934:
URL: https://github.com/apache/incubator-nuttx/pull/2934


   ## Summary
   There is a typo in `__stack_overflow_trap` declaration for armv7-m.
   Due to this, although the code builds fine, the `__attribute__((naked, no_instrument_function))` is not applied.
   
   When stack check was enabled, the `__stack_overflow_trap` was instrumented, causing endless recursive calls to itself.
   
   ## Impact
   Now this function is properly working.
   
   ## Testing
   Created a stack overflow with the following simply defined in a function:
   ```c
   uint8_t overflow_buffer[4096];  //Much larger than the stack.
   ```
   
   Before the code was entering an endless recursion of calls to `__stack_overflow_trap`.  
   Now the trap is properly executed.
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] davids5 merged pull request #2934: Fixed __stack_overflow_trap declaration typo.

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #2934:
URL: https://github.com/apache/incubator-nuttx/pull/2934


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #2934: Fixed __stack_overflow_trap declaration typo.

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2934:
URL: https://github.com/apache/incubator-nuttx/pull/2934#issuecomment-786759316


   Good catch @fjpanag !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org