[jira] [Commented] (WHIRR-339) Allow to specify hbase-site.xml properties through cluster configuration file

["Tom White (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIRR-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066114#comment-13066114 ] 

Tom White commented on WHIRR-339:
---------------------------------

This looks good - thanks for working on it.

> I dropped the setting of "hbase-site.hbase.client.retries.number=100" because I'm not sure we should divert from the HBase default there.

hbase-site.hbase.client.retries.number was increased from the default due to problems we were having as described in WHIRR-314. So I think we should keep it in the absence of a better solution.

Have you managed to run the HBase integration tests with this change?

> Solving this is a topic of its own.

Worth opening a JIRA for this?

> Allow to specify hbase-site.xml properties through cluster configuration file
> -----------------------------------------------------------------------------
>
>                 Key: WHIRR-339
>                 URL: https://issues.apache.org/jira/browse/WHIRR-339
>             Project: Whirr
>          Issue Type: Improvement
>          Components: service/hbase
>            Reporter: Bruno Dumon
>         Attachments: WHIRR-339.patch
>
>
> Currently the hbase-site.xml configuration is hardcoded in the configure(_cdh)_hbase.sh script. This patch adds dynamic generation of hbase-site.xml, modelled after what is done for hadoop-(common|mapred|hdfs)-site.xml.
> The user is able to specify custom properties in their cluster configuration, by prefixing them with 'hbase-site.'
> Default config is in whirr-hbase-default.properties. Compared to what was in configure_hbase.sh before, I dropped the setting of "hbase-site.hbase.client.retries.number=100" because I'm not sure we should divert from the HBase default there.
> I left in the passing of the ZOOKEEPER_QUORUM to the configure script, as I figured people using custom scripts might still want to have it (there's a PORT variable passed that doesn't seem to be used either).
> On a more general note, this patch has the same limitations as for Hadoop: running master and regionserver on same node will not work as the configuration will be appended twice to the same file, and running the restserver/thriftserver not together with regionserver or master will fail due to missing hbase-site.xml. Solving this is a topic of its own.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira