[GitHub] cloud-fan commented on a change in pull request #23853: [SPARK-26952][SQL] Row count statics should respect the data reported by data source

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #23853: [SPARK-26952][SQL] Row count statics should respect the data reported by data source
URL: https://github.com/apache/spark/pull/23853#discussion_r259344107
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
 ##########
 @@ -56,7 +56,14 @@ case class DataSourceV2Relation(
     scan match {
       case r: SupportsReportStatistics =>
         val statistics = r.estimateStatistics()
-        Statistics(sizeInBytes = statistics.sizeInBytes().orElse(conf.defaultSizeInBytes))
+        val numRows: Option[BigInt] = if (statistics.numRows().isPresent) {
+          Some(statistics.numRows().getAsLong)
+        } else {
+          None
+        }
+        Statistics(
 
 Review comment:
   shall we create a util method to turn v2 statistics to spark statistics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org