You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by il...@apache.org on 2017/11/16 08:03:19 UTC

[2/2] syncope git commit: [SYNCOPE-1234] Forgot to consider the profile parameter

[SYNCOPE-1234] Forgot to consider the profile parameter


Project: http://git-wip-us.apache.org/repos/asf/syncope/repo
Commit: http://git-wip-us.apache.org/repos/asf/syncope/commit/39d507d4
Tree: http://git-wip-us.apache.org/repos/asf/syncope/tree/39d507d4
Diff: http://git-wip-us.apache.org/repos/asf/syncope/diff/39d507d4

Branch: refs/heads/master
Commit: 39d507d4945489546cba69cb160996d4798c72a2
Parents: 33daf27
Author: Francesco Chicchiriccò <il...@apache.org>
Authored: Thu Nov 16 08:38:35 2017 +0100
Committer: Francesco Chicchiriccò <il...@apache.org>
Committed: Thu Nov 16 09:03:06 2017 +0100

----------------------------------------------------------------------
 .../syncope/core/provisioning/api/pushpull/PullActions.java       | 3 ++-
 .../provisioning/java/pushpull/AbstractPullResultHandler.java     | 2 +-
 .../provisioning/java/pushpull/DefaultRealmPullResultHandler.java | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/syncope/blob/39d507d4/core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java
----------------------------------------------------------------------
diff --git a/core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java b/core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java
index bcf20c3..d367a7e 100644
--- a/core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java
+++ b/core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/PullActions.java
@@ -33,10 +33,11 @@ public interface PullActions extends ProvisioningActions {
     /**
      * Pre-process the pull information received by the underlying connector, before any internal activity occurs.
      *
+     * @param profile profile of the pull being executed.
      * @param delta retrieved pull information
      * @return pull information, possibly altered.
      */
-    default SyncDelta preprocess(final SyncDelta delta) {
+    default SyncDelta preprocess(ProvisioningProfile<?, ?> profile, SyncDelta delta) {
         return delta;
     }
 

http://git-wip-us.apache.org/repos/asf/syncope/blob/39d507d4/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPullResultHandler.java
----------------------------------------------------------------------
diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPullResultHandler.java
index dd7e4ef..0a74cb3 100644
--- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPullResultHandler.java
+++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/AbstractPullResultHandler.java
@@ -727,7 +727,7 @@ public abstract class AbstractPullResultHandler extends AbstractSyncopeResultHan
 
         SyncDelta processed = delta;
         for (PullActions action : profile.getActions()) {
-            processed = action.preprocess(processed);
+            processed = action.preprocess(profile, processed);
         }
 
         LOG.debug("Transformed {} for {} as {}",

http://git-wip-us.apache.org/repos/asf/syncope/blob/39d507d4/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
----------------------------------------------------------------------
diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
index b3b12ea..dae9b89 100644
--- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
+++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultRealmPullResultHandler.java
@@ -671,7 +671,7 @@ public class DefaultRealmPullResultHandler
 
         SyncDelta processed = delta;
         for (PullActions action : profile.getActions()) {
-            processed = action.preprocess(processed);
+            processed = action.preprocess(profile, processed);
         }
 
         LOG.debug("Transformed {} for {} as {}",