You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/14 12:14:31 UTC
[GitHub] [pulsar] guillaume-braibant opened a new pull request #4951: Fix
pull request 4700
guillaume-braibant opened a new pull request #4951: Fix pull request 4700
URL: https://github.com/apache/pulsar/pull/4951
### Purpose
Fixes pull request #4700
### Motivation
The updated API (using v1/apps for Workload API objects like DaemonSet, StatefulSet, and Deployment) introduced in #4700 requires a LabelSelector object for each Deployment, DaemonSet, and SatetfulSet object. The #4700 does not include those LabelSelector objects. This causes the rejection of the K8S generic deployment scripts by the K8S API validator.
### Changes
_deployment/kubernetes/generic/k8s-1-9-and-above/bookie.yml :_
- Add a LabelSelector object matching pods labels (required by API)
to the DaemonSet:spec object
_deployment/kubernetes/generic/k8s-1-9-and-above/broker.yml :_
- Add a LabelSelector object matching pods labels (required by API)
to the Deployment:spec object .
_deployment/kubernetes/generic/k8s-1-9-and-above/monitoring.yml :_
- Add a LabelSelector object matching pods labels (required by API)
to the Deployment:spec object for Prometheus.
- Add a LabelSelector object matching pods labels (required by API)
to the Deployment:spec object for Grafana.
- Add a LabelSelector object matching pods labels (required by API)
to the Deployment:spec object for the Pulsar Dashboard.
_deployment/kubernetes/generic/k8s-1-9-and-above/proxy.yml :_
- Add a LabelSelector object matching pods labels (required by API)
to the Deployment:spec object.
_deployment/kubernetes/generic/k8s-1-9-and-above/proxy.yml :_
- Add a LabelSelector object matching pods labels (required by API)
to the StatefulSet:spec object.
- Changing StatefulSet:spec:template:metadata:labels:cluster from 'us-central' to 'local'. All other scripts assume cluster is 'local' and not 'us-central'.
### Testing coverage
- All scripts have been succefully applied to a fresh Minikube cluster without rejection
- Cluster experiment (through admin pod) with a production rate of 100 has been done
- Monitoring has NOT been tested (deployed but not functionally tested)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services