You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mebelousov <gi...@git.apache.org> on 2018/07/18 13:19:18 UTC
[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...
GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/3081
ZEPPELIN-3575. Add 'Copy Column Name' button in visualization table
### What is this PR for?
Add button to drop-down list in visualization table to copy column name.
I know that column name could be obtained in a different way, for example, by auto-complete.
Nevertheless I think this feature is comfortable.
### What type of PR is it?
Feature
### What is the Jira issue?
[ZEPPELIN-3575](https://issues.apache.org/jira/browse/ZEPPELIN-3575)
### How should this be tested?
* Manually
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3081
----
commit efa95b6ee19387b4aec02ab99cf313a06bb6618c
Author: Maxim Belousov <me...@...>
Date: 2018-07-18T13:10:51Z
ZEPPELIN-3575 - Add 'Copy Column Name' button in visualization table
----
---
[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3081
@jongyoul I also haven't good idea to write small and useful test.
It's possible to rewrite copyStringToClipboard as pass to function the column number and then put in clipboard column name, although it's not straightforward way.
---
[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3081
Sorry for the late reply. How about adding an integration test?
---
[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov closed the pull request at:
https://github.com/apache/zeppelin/pull/3081
---
[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...
Posted by mebelousov <gi...@git.apache.org>.
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3081
Will try to revert with tests.
---