[GitHub] [beam] Abacn commented on a diff in pull request #24205: Update Kafka watermark based on policy when records poll empty

[GitBox <gi...@apache.org>]

Abacn commented on code in PR #24205:
URL: https://github.com/apache/beam/pull/24205#discussion_r1030629314


##########
sdks/java/io/kafka/build.gradle:
##########
@@ -148,6 +148,7 @@ kafkaVersions.each {kv ->
       if (!(kv.key in sdfKafkaVersions)) excludeTestsMatching "*DynamicPartitions" //admin client create partitions does not exist in kafka 0.11.0.3 and kafka sdf does not appear to work for kafka versions <2.0.1
       if (!(kv.key in sdfKafkaVersions)) excludeTestsMatching "*SDFResumesCorrectly" //Kafka SDF does not work for kafka versions <2.0.1
       if (!(kv.key in sdfKafkaVersions)) excludeTestsMatching "*StopReadingFunction" //Kafka SDF does not work for kafka versions <2.0.1
+      if (!(kv.key in sdfKafkaVersions)) excludeTestsMatching "*WatermarkUpdateWithSparseMessages" //Kafka SDF does not work for kafka versions <2.0.1

Review Comment:
   minor. since there are multiple exclude with same condition.
   ```
   if (!(kv.key in sdfKafkaVersions)) {
     excludeTestsMatching ...
     excludeTestsMatching ...
   }
   ```



##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java:
##########
@@ -430,6 +429,19 @@ public ProcessContinuation processElement(
     }
   }
 
+  private TimestampPolicyContext updateWatermark(

Review Comment:
   consider naming 'updateWatermarkManually' ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org