[GitHub] lucene-solr pull request #34: Move hdfs stuff out into a new contrib

[tomjon <gi...@git.apache.org>]

Github user tomjon commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/34#discussion_r66244222
  
    --- Diff: lucene/core/src/java/org/apache/lucene/store/Directory.java ---
    @@ -165,4 +165,13 @@ public void copyFrom(Directory from, String src, String dest, IOContext context)
        * @throws AlreadyClosedException if this Directory is closed
        */
       protected void ensureOpen() throws AlreadyClosedException {}
    +  
    --- End diff --
    
    This change was made to eliminate the "instanceof HdfsDirectory" in the fileModified() method of BlockDirectory.  The polymorphism solution seemed best, but as you say, means modifying Lucene classes (all the relevant subclasses of Directory are in Lucene, except HdfsDirectory)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org